Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: components/safe_browsing/base_blocking_page.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)
Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/base_blocking_page.cc
diff --git a/components/safe_browsing/base_blocking_page.cc b/components/safe_browsing/base_blocking_page.cc
index 184a1b2bbb8d7c988a55deab11661c1f7481563a..674fd63ca2eaeb9e41a932b202ca96ec4b963197 100644
--- a/components/safe_browsing/base_blocking_page.cc
+++ b/components/safe_browsing/base_blocking_page.cc
@@ -283,14 +283,14 @@ BaseBlockingPage::GetInterstitialReason(
const BaseUIManager::UnsafeResource& resource = *iter;
safe_browsing::SBThreatType threat_type = resource.threat_type;
if (threat_type == SB_THREAT_TYPE_URL_MALWARE ||
- threat_type == SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL) {
+ threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE) {
return BaseSafeBrowsingErrorUI::SB_REASON_MALWARE;
} else if (threat_type == SB_THREAT_TYPE_URL_UNWANTED) {
harmful = true;
} else {
DCHECK(threat_type == SB_THREAT_TYPE_URL_PHISHING ||
- threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL ||
- threat_type == SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL);
+ threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING ||
+ threat_type == SB_THREAT_TYPE_URL_PASSWORD_PROTECTION_PHISHING);
}
}
« no previous file with comments | « chrome/browser/ui/webui/interstitials/interstitial_ui.cc ('k') | components/safe_browsing/base_ping_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698