Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 6 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, dominickn+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, yzshen+watch_chromium.org, net-reviews_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, jdonnelly+watch_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, wanming.lin, chfremer+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, huangml+watch_chromium.org, gogerald+paymentswatch_chromium.org, cc-bugs_chromium.org, extensions-reviews_chromium.org, timvolodine, rouslan+payments_chromium.org, feature-vr-reviews_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, shalamov, feature-media-reviews_chromium.org, liaoyuke+watch_chromium.org, Eugene But (OOO till 7-30), blink-reviews-api_chromium.org, Aaron Boodman, mahmadi+paymentswatch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: flip the default value of use_new_js_bindings to true. BUG=699569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2910703004 Cr-Commit-Position: refs/heads/master@{#475327} Committed: https://chromium.googlesource.com/chromium/src/+/eae56c386f559a286494aeb58f7fd9857efd960d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -21 lines) Patch
M chrome/browser/engagement/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/usb_internals/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/media_router/mojo/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M components/payments/mojom/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M device/bluetooth/public/interfaces/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download
M device/generic_sensor/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M device/geolocation/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M device/usb/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M device/vr/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M media/capture/mojo/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 12 chunks +0 lines, -15 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +4 lines, -4 lines 0 comments Download
M net/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M services/device/public/interfaces/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M services/service_manager/public/interfaces/BUILD.gn View 1 2 chunks +6 lines, -0 lines 0 comments Download
M services/shape_detection/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M url/mojo/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
yzshen1
Hi, John. Would you please review this CL? Thanks! This CL explicitly sets use_new_js_bindings=false for ...
3 years, 7 months ago (2017-05-26 22:34:19 UTC) #6
jam
lgtm
3 years, 7 months ago (2017-05-26 22:46:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910703004/20001
3 years, 6 months ago (2017-05-27 14:54:40 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/449535)
3 years, 6 months ago (2017-05-27 15:02:36 UTC) #18
yzshen1
Hi, Daniel. Would you please do an OWNER review for gpu/ipc/common/BUILD.gn? This change doesn't change ...
3 years, 6 months ago (2017-05-27 23:55:42 UTC) #20
dcheng
lgtm LGTM
3 years, 6 months ago (2017-05-29 08:03:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910703004/20001
3 years, 6 months ago (2017-05-29 08:03:19 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/395012)
3 years, 6 months ago (2017-05-29 09:17:28 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910703004/20001
3 years, 6 months ago (2017-05-29 09:34:02 UTC) #27
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 10:01:02 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eae56c386f559a286494aeb58f7f...

Powered by Google App Engine
This is Rietveld 408576698