Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: mojo/edk/js/tests/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/common/BUILD.gn ('k') | mojo/public/interfaces/bindings/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//mojo/public/tools/bindings/mojom.gni") 5 import("//mojo/public/tools/bindings/mojom.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 # TODO(hansmuller): The organization of tests in this directory is weird: 8 # TODO(hansmuller): The organization of tests in this directory is weird:
9 # * Really, js_unittests tests public stuff, so that should live in public 9 # * Really, js_unittests tests public stuff, so that should live in public
10 # and be reworked as some sort of apptest. 10 # and be reworked as some sort of apptest.
(...skipping 30 matching lines...) Expand all
41 "js_to_cpp_tests.js", 41 "js_to_cpp_tests.js",
42 ] 42 ]
43 43
44 configs += [ "//v8:external_startup_data" ] 44 configs += [ "//v8:external_startup_data" ]
45 } 45 }
46 46
47 mojom("js_to_cpp_bindings") { 47 mojom("js_to_cpp_bindings") {
48 sources = [ 48 sources = [
49 "js_to_cpp.mojom", 49 "js_to_cpp.mojom",
50 ] 50 ]
51
52 # TODO(crbug.com/699569): Convert to use the new JS bindings.
53 use_new_js_bindings = false
51 } 54 }
52 55
53 test("mojo_js_unittests") { 56 test("mojo_js_unittests") {
54 deps = [ 57 deps = [
55 "//base", 58 "//base",
56 "//gin:gin_test", 59 "//gin:gin_test",
57 "//mojo/edk/js", 60 "//mojo/edk/js",
58 "//mojo/edk/test:run_all_unittests", 61 "//mojo/edk/test:run_all_unittests",
59 "//mojo/edk/test:test_support", 62 "//mojo/edk/test:test_support",
60 "//mojo/public/cpp/system", 63 "//mojo/public/cpp/system",
61 "//mojo/public/interfaces/bindings/tests:test_associated_interfaces", 64 "//mojo/public/interfaces/bindings/tests:test_associated_interfaces",
62 "//mojo/public/interfaces/bindings/tests:test_interfaces", 65 "//mojo/public/interfaces/bindings/tests:test_interfaces",
63 "//mojo/public/js:tests", 66 "//mojo/public/js:tests",
64 ] 67 ]
65 68
66 sources = [ 69 sources = [
67 "//mojo/edk/js/handle_unittest.cc", 70 "//mojo/edk/js/handle_unittest.cc",
68 "run_js_unittests.cc", 71 "run_js_unittests.cc",
69 ] 72 ]
70 } 73 }
OLDNEW
« no previous file with comments | « mojo/common/BUILD.gn ('k') | mojo/public/interfaces/bindings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698