Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: url/mojo/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gfx/geometry/mojo/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//mojo/public/tools/bindings/mojom.gni") 5 import("//mojo/public/tools/bindings/mojom.gni")
6 6
7 mojom("url_mojom_gurl") { 7 mojom("url_mojom_gurl") {
8 sources = [ 8 sources = [
9 "url.mojom", 9 "url.mojom",
10 ] 10 ]
11
12 # TODO(crbug.com/699569): Convert to use the new JS bindings.
13 use_new_js_bindings = false
11 } 14 }
12 15
13 mojom("url_mojom_origin") { 16 mojom("url_mojom_origin") {
14 sources = [ 17 sources = [
15 "origin.mojom", 18 "origin.mojom",
16 ] 19 ]
17 20
18 public_deps = [ 21 public_deps = [
19 ":url_mojom_gurl", 22 ":url_mojom_gurl",
20 ] 23 ]
24
25 # TODO(crbug.com/699569): Convert to use the new JS bindings.
26 use_new_js_bindings = false
21 } 27 }
22 28
23 mojom("test_url_mojom_gurl") { 29 mojom("test_url_mojom_gurl") {
24 sources = [ 30 sources = [
25 "url_test.mojom", 31 "url_test.mojom",
26 ] 32 ]
27 33
28 public_deps = [ 34 public_deps = [
29 ":url_mojom_gurl", 35 ":url_mojom_gurl",
30 ":url_mojom_origin", 36 ":url_mojom_origin",
31 ] 37 ]
32 38
33 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback. 39 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
34 use_once_callback = false 40 use_once_callback = false
35 } 41 }
OLDNEW
« no previous file with comments | « ui/gfx/geometry/mojo/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698