Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: mojo/public/tools/bindings/mojom.gni

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Indicates whether typemapping should be supported in this build 6 # Indicates whether typemapping should be supported in this build
7 # configuration. This may be disabled when building external projects which 7 # configuration. This may be disabled when building external projects which
8 # depend on //mojo but which do not need/want all of the Chromium tree 8 # depend on //mojo but which do not need/want all of the Chromium tree
9 # dependencies that come with typemapping. 9 # dependencies that come with typemapping.
10 # 10 #
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 # TODO(dcheng): 142 # TODO(dcheng):
143 # - Convert everything to use OnceCallback. 143 # - Convert everything to use OnceCallback.
144 # - Remove support for the old mode. 144 # - Remove support for the old mode.
145 # 145 #
146 # cpp_only (optional) 146 # cpp_only (optional)
147 # If set to true, only the C++ bindings targets will be generated. 147 # If set to true, only the C++ bindings targets will be generated.
148 # 148 #
149 # use_new_js_bindings (optional) 149 # use_new_js_bindings (optional)
150 # If set to true, the generated JS code will use the new module loading 150 # If set to true, the generated JS code will use the new module loading
151 # approach and the core API exposed by Web IDL. 151 # approach and the core API exposed by Web IDL.
152 # 152 # Default value is true.
153 # TODO(yzshen): Switch all existing users to use_new_js_bindings=true and 153 # TODO(yzshen): Convert all users to use new JS bindings and remove the
154 # remove the old mode. 154 # old mode.
155 # 155 #
156 # component_output_prefix (optional) 156 # component_output_prefix (optional)
157 # The prefix to use for the output_name of any component library emitted 157 # The prefix to use for the output_name of any component library emitted
158 # for generated C++ bindings. If this is omitted, C++ bindings targets are 158 # for generated C++ bindings. If this is omitted, C++ bindings targets are
159 # emitted as source_sets instead. Because this controls the name of the 159 # emitted as source_sets instead. Because this controls the name of the
160 # output shared library binary in the root output directory, it must be 160 # output shared library binary in the root output directory, it must be
161 # unique across the entire build configuration. 161 # unique across the entire build configuration.
162 # 162 #
163 # This is required if |component_macro_prefix| is specified. 163 # This is required if |component_macro_prefix| is specified.
164 # 164 #
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 "--export_header", 618 "--export_header",
619 invoker.export_header, 619 invoker.export_header,
620 ] 620 ]
621 } 621 }
622 } 622 }
623 623
624 if (!defined(invoker.use_once_callback) || invoker.use_once_callback) { 624 if (!defined(invoker.use_once_callback) || invoker.use_once_callback) {
625 args += [ "--use_once_callback" ] 625 args += [ "--use_once_callback" ]
626 } 626 }
627 627
628 if (defined(invoker.use_new_js_bindings) && 628 if (!defined(invoker.use_new_js_bindings) ||
629 invoker.use_new_js_bindings) { 629 invoker.use_new_js_bindings) {
630 args += [ "--use_new_js_bindings" ] 630 args += [ "--use_new_js_bindings" ]
631 } 631 }
632 } 632 }
633 } 633 }
634 634
635 action(type_mappings_target_name) { 635 action(type_mappings_target_name) {
636 inputs = _bindings_configuration_files 636 inputs = _bindings_configuration_files
637 outputs = [ 637 outputs = [
638 type_mappings_path, 638 type_mappings_path,
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 forward_variables_from(invoker, 870 forward_variables_from(invoker,
871 "*", 871 "*",
872 [ 872 [
873 "output_prefix", 873 "output_prefix",
874 "macro_prefix", 874 "macro_prefix",
875 ]) 875 ])
876 component_output_prefix = invoker.output_prefix 876 component_output_prefix = invoker.output_prefix
877 component_macro_prefix = invoker.macro_prefix 877 component_macro_prefix = invoker.macro_prefix
878 } 878 }
879 } 879 }
OLDNEW
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698