Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: mojo/public/interfaces/bindings/tests/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/interfaces/bindings/BUILD.gn ('k') | mojo/public/tools/bindings/mojom.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/interfaces/bindings/tests/BUILD.gn
diff --git a/mojo/public/interfaces/bindings/tests/BUILD.gn b/mojo/public/interfaces/bindings/tests/BUILD.gn
index 9cd84d43fc89d4baf5edcd2e0af4c25c91939db0..17f1f1b22897d83761aa64499b19d495b1aab2eb 100644
--- a/mojo/public/interfaces/bindings/tests/BUILD.gn
+++ b/mojo/public/interfaces/bindings/tests/BUILD.gn
@@ -69,7 +69,6 @@ mojom("test_interfaces") {
":test_mojom_import",
":test_mojom_import2",
]
- use_new_js_bindings = true
# TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
use_once_callback = false
@@ -109,7 +108,6 @@ mojom("test_export") {
if (!is_ios) {
visibility_blink = [ ":test_export_blink_component" ]
}
- use_new_js_bindings = true
}
mojom("test_exported_import") {
@@ -127,7 +125,6 @@ mojom("test_exported_import") {
overridden_deps_blink = [ ":test_export" ]
component_deps_blink = [ ":test_export_blink_component" ]
}
- use_new_js_bindings = true
}
# Used to test that it is okay to call mojom::Foo::Serialize()/Deserialize()
@@ -153,7 +150,6 @@ mojom("test_export2") {
export_define = "MOJO_TEST_IMPLEMENTATION=1"
export_header = "mojo/public/cpp/bindings/tests/mojo_test_export.h"
visibility = [ ":test_export_component2" ]
- use_new_js_bindings = true
}
mojom("test_mojom_import") {
@@ -161,7 +157,6 @@ mojom("test_mojom_import") {
sources = [
"sample_import.mojom",
]
- use_new_js_bindings = true
}
mojom("test_mojom_import_wrapper") {
@@ -187,7 +182,6 @@ mojom("test_mojom_import2") {
":test_mojom_import",
":test_mojom_import_wrapper_wrapper",
]
- use_new_js_bindings = true
}
mojom("test_struct_traits_interfaces") {
@@ -196,8 +190,6 @@ mojom("test_struct_traits_interfaces") {
"struct_with_traits.mojom",
]
- use_new_js_bindings = true
-
# TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
use_once_callback = false
}
@@ -215,8 +207,6 @@ mojom("test_associated_interfaces") {
":test_interfaces",
]
- use_new_js_bindings = true
-
# TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
use_once_callback = false
}
@@ -226,7 +216,6 @@ mojom("versioning_test_service_interfaces") {
sources = [
"versioning_test_service.mojom",
]
- use_new_js_bindings = true
}
mojom("versioning_test_client_interfaces") {
@@ -234,7 +223,6 @@ mojom("versioning_test_client_interfaces") {
sources = [
"versioning_test_client.mojom",
]
- use_new_js_bindings = true
}
mojom("test_wtf_types") {
@@ -244,8 +232,6 @@ mojom("test_wtf_types") {
"test_wtf_types.mojom",
]
- use_new_js_bindings = true
-
# TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
use_once_callback = false
}
@@ -264,5 +250,4 @@ mojom("echo") {
"echo.mojom",
"echo_import.mojom",
]
- use_new_js_bindings = true
}
« no previous file with comments | « mojo/public/interfaces/bindings/BUILD.gn ('k') | mojo/public/tools/bindings/mojom.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698