Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index 1d3b81bfbe8208750b5bb7678713ba6b37549448..8708e7a22895d22aaa7926d7fc2b5a560ba36d1c 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -149,9 +149,9 @@ if (enable_mojom_typemapping) {
# use_new_js_bindings (optional)
# If set to true, the generated JS code will use the new module loading
# approach and the core API exposed by Web IDL.
-#
-# TODO(yzshen): Switch all existing users to use_new_js_bindings=true and
-# remove the old mode.
+# Default value is true.
+# TODO(yzshen): Convert all users to use new JS bindings and remove the
+# old mode.
#
# component_output_prefix (optional)
# The prefix to use for the output_name of any component library emitted
@@ -625,7 +625,7 @@ template("mojom") {
args += [ "--use_once_callback" ]
}
- if (defined(invoker.use_new_js_bindings) &&
+ if (!defined(invoker.use_new_js_bindings) ||
invoker.use_new_js_bindings) {
args += [ "--use_new_js_bindings" ]
}
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698