Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/public/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/shape_detection/public/interfaces/BUILD.gn ('k') | ui/gfx/geometry/mojo/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//mojo/public/tools/bindings/mojom.gni") 6 import("//mojo/public/tools/bindings/mojom.gni")
7 import("//third_party/WebKit/public/public_features.gni") 7 import("//third_party/WebKit/public/public_features.gni")
8 import("//third_party/WebKit/Source/config.gni") 8 import("//third_party/WebKit/Source/config.gni")
9 import("//third_party/WebKit/Source/core/core.gni") 9 import("//third_party/WebKit/Source/core/core.gni")
10 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 export_header = "content/common/content_export.h" 750 export_header = "content/common/content_export.h"
751 751
752 # Similarly, the blink variant must be linked with the platform component 752 # Similarly, the blink variant must be linked with the platform component
753 # since it uses types from it in its typemaps. 753 # since it uses types from it in its typemaps.
754 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT" 754 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT"
755 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1" 755 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
756 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h" 756 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h"
757 757
758 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback. 758 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
759 use_once_callback = false 759 use_once_callback = false
760
761 # TODO(crbug.com/699569): Convert to use the new JS bindings.
762 use_new_js_bindings = false
760 } 763 }
761 764
762 mojom("android_mojo_bindings") { 765 mojom("android_mojo_bindings") {
763 visibility = [ ":mojo_bindings" ] 766 visibility = [ ":mojo_bindings" ]
764 visibility_blink = [ ":mojo_bindings_blink" ] 767 visibility_blink = [ ":mojo_bindings_blink" ]
765 sources = [ 768 sources = [
766 "platform/modules/document_metadata/copyless_paste.mojom", 769 "platform/modules/document_metadata/copyless_paste.mojom",
767 "platform/modules/installation/installation.mojom", 770 "platform/modules/installation/installation.mojom",
768 "platform/modules/installedapp/installed_app_provider.mojom", 771 "platform/modules/installedapp/installed_app_provider.mojom",
769 "platform/modules/installedapp/related_application.mojom", 772 "platform/modules/installedapp/related_application.mojom",
(...skipping 12 matching lines...) Expand all
782 # See comment above. 785 # See comment above.
783 export_class_attribute = "CONTENT_EXPORT" 786 export_class_attribute = "CONTENT_EXPORT"
784 export_define = "CONTENT_IMPLEMENTATION=1" 787 export_define = "CONTENT_IMPLEMENTATION=1"
785 export_header = "content/common/content_export.h" 788 export_header = "content/common/content_export.h"
786 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT" 789 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT"
787 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1" 790 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
788 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h" 791 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h"
789 792
790 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback. 793 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
791 use_once_callback = false 794 use_once_callback = false
795
796 # TODO(crbug.com/699569): Convert to use the new JS bindings.
797 use_new_js_bindings = false
792 } 798 }
793 799
794 # The offscreen_canvas_mojo_bindings is separated from the rest of mojom files 800 # The offscreen_canvas_mojo_bindings is separated from the rest of mojom files
795 # because its deps contain too many files in Chromium that would pollute the 801 # because its deps contain too many files in Chromium that would pollute the
796 # include paths in generated mojom-blink files for other services. 802 # include paths in generated mojom-blink files for other services.
797 mojom("offscreen_canvas_mojo_bindings") { 803 mojom("offscreen_canvas_mojo_bindings") {
798 visibility = [ "//content/*" ] 804 visibility = [ "//content/*" ]
799 visibility_blink = [ "//third_party/WebKit/Source/platform" ] 805 visibility_blink = [ "//third_party/WebKit/Source/platform" ]
800 sources = [ 806 sources = [
801 "platform/modules/offscreencanvas/offscreen_canvas_surface.mojom", 807 "platform/modules/offscreencanvas/offscreen_canvas_surface.mojom",
(...skipping 28 matching lines...) Expand all
830 sources = [ 836 sources = [
831 "web/ConsoleMessageStructTraits.cpp", 837 "web/ConsoleMessageStructTraits.cpp",
832 "web/ConsoleMessageStructTraits.h", 838 "web/ConsoleMessageStructTraits.h",
833 ] 839 ]
834 deps = [ 840 deps = [
835 ":blink_headers", 841 ":blink_headers",
836 ":mojo_bindings_shared__generator", 842 ":mojo_bindings_shared__generator",
837 "//mojo/public/cpp/bindings:struct_traits", 843 "//mojo/public/cpp/bindings:struct_traits",
838 ] 844 ]
839 } 845 }
OLDNEW
« no previous file with comments | « services/shape_detection/public/interfaces/BUILD.gn ('k') | ui/gfx/geometry/mojo/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698