Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: mojo/public/interfaces/bindings/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/js/tests/BUILD.gn ('k') | mojo/public/interfaces/bindings/tests/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../../tools/bindings/mojom.gni") 5 import("../../tools/bindings/mojom.gni")
6 6
7 mojom("bindings") { 7 mojom("bindings") {
8 visibility = [] 8 visibility = []
9 sources = [ 9 sources = [
10 "interface_control_messages.mojom", 10 "interface_control_messages.mojom",
11 "pipe_control_messages.mojom", 11 "pipe_control_messages.mojom",
12 ] 12 ]
13 13
14 component_output_prefix = "mojo_public_interfaces_bindings" 14 component_output_prefix = "mojo_public_interfaces_bindings"
15 export_class_attribute = "MOJO_CPP_BINDINGS_EXPORT" 15 export_class_attribute = "MOJO_CPP_BINDINGS_EXPORT"
16 export_define = "MOJO_CPP_BINDINGS_IMPLEMENTATION" 16 export_define = "MOJO_CPP_BINDINGS_IMPLEMENTATION"
17 export_header = "mojo/public/cpp/bindings/bindings_export.h" 17 export_header = "mojo/public/cpp/bindings/bindings_export.h"
18 18
19 export_class_attribute_shared = "MOJO_CPP_BINDINGS_EXPORT" 19 export_class_attribute_shared = "MOJO_CPP_BINDINGS_EXPORT"
20 export_define_shared = "MOJO_CPP_BINDINGS_IMPLEMENTATION" 20 export_define_shared = "MOJO_CPP_BINDINGS_IMPLEMENTATION"
21 export_header_shared = "mojo/public/cpp/bindings/bindings_export.h" 21 export_header_shared = "mojo/public/cpp/bindings/bindings_export.h"
22
23 use_new_js_bindings = false
22 } 24 }
23 25
24 # TODO(yzshen): Remove this target and use the one above once 26 # TODO(yzshen): Remove this target and use the one above once
25 # |use_new_js_bindings| becomes true by default. 27 # |use_new_js_bindings| becomes true by default.
26 mojom("new_bindings") { 28 mojom("new_bindings") {
27 visibility = [] 29 visibility = []
28 sources = [ 30 sources = [
29 "new_bindings/interface_control_messages.mojom", 31 "new_bindings/interface_control_messages.mojom",
30 "new_bindings/pipe_control_messages.mojom", 32 "new_bindings/pipe_control_messages.mojom",
31 ] 33 ]
32
33 use_new_js_bindings = true
34 } 34 }
OLDNEW
« no previous file with comments | « mojo/edk/js/tests/BUILD.gn ('k') | mojo/public/interfaces/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698