Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2046)

Unified Diff: chrome/browser/engagement/BUILD.gn

Issue 2910703004: Mojo JS bindings: flip the default value of use_new_js_bindings to true. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/omnibox/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/BUILD.gn
diff --git a/chrome/browser/engagement/BUILD.gn b/chrome/browser/engagement/BUILD.gn
index 3bca05363d53123f5c552a820cc85768a08f2fb9..2f45dd439d7ebd330b7e87f3ddcafce27f3934ed 100644
--- a/chrome/browser/engagement/BUILD.gn
+++ b/chrome/browser/engagement/BUILD.gn
@@ -15,4 +15,7 @@ mojom("mojo_bindings") {
# TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
use_once_callback = false
+
+ # TODO(crbug.com/699569): Convert to use the new JS bindings.
+ use_new_js_bindings = false
}
« no previous file with comments | « no previous file | chrome/browser/ui/webui/omnibox/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698