Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Created:
3 years, 7 months ago by huangml
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, noyau+watch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org, Mark Mentovai
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (patchset #10 id:200001 of https://codereview.chromium.org/2610923005/ ) Reason for revert: Revert the CL as some iOS tests are failing due to releasing issues. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27565 Original issue's description: > Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. > > Review-Url: https://codereview.chromium.org/2610923005 > Cr-Commit-Position: refs/heads/master@{#471754} > Committed: https://chromium.googlesource.com/chromium/src/+/6c018d86b723aee46a2f80cf403a3fabc3bbd7a1 TBR=rohitrao@chromium.org,sdefresne@chromium.org,sdy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2881183002 Cr-Commit-Position: refs/heads/master@{#471832} Committed: https://chromium.googlesource.com/chromium/src/+/77173bd1188bd886c1bd940e014587cad265f44f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -134 lines) Patch
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 3 chunks +8 lines, -6 lines 0 comments Download
M components/handoff/handoff_manager.mm View 4 chunks +3 lines, -6 lines 0 comments Download
M ios/chrome/app/main_controller.mm View 5 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.mm View 3 chunks +10 lines, -4 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache.mm View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/authentication/authentication_flow.mm View 3 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/elements/activity_overlay_coordinator.mm View 2 chunks +12 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/main/browser_view_wrangler.mm View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar.mm View 4 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm View 4 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_view.mm View 4 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm View 4 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm View 4 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm View 3 chunks +7 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm View 2 chunks +11 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_view.mm View 4 chunks +5 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.mm View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_strip_controller.mm View 4 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_view.mm View 4 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 3 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm View 5 chunks +9 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm View 4 chunks +7 lines, -7 lines 0 comments Download
M ios/web/public/origin_util_unittest.mm View 2 chunks +9 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
huangml
Created Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.
3 years, 7 months ago (2017-05-15 18:10:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881183002/1
3 years, 7 months ago (2017-05-15 18:11:36 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-15 18:11:38 UTC) #5
huangml
3 years, 7 months ago (2017-05-15 18:12:31 UTC) #7
baxley
On 2017/05/15 18:12:31, huangml wrote: LGTM
3 years, 7 months ago (2017-05-15 18:14:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881183002/1
3 years, 7 months ago (2017-05-15 18:15:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:16:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77173bd1188bd886c1bd940e0145...

Powered by Google App Engine
This is Rietveld 408576698