Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Review-Url: https://codereview.chromium.org/2610923005
Cr-Commit-Position: refs/heads/master@{#471754}
Committed: https://chromium.googlesource.com/chromium/src/+/6c018d86b723aee46a2f80cf403a3fabc3bbd7a1

[Sidney San Martín, 2017-01-04 21:21:24]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:21:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:31:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sidney San Martín, 2017-01-04 21:37:17]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sidney San Martín, 2017-01-04 21:40:55]

Description was changed from

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

TBR=jam@chromium.org
==========

to

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.
==========

[Sidney San Martín, 2017-01-04 21:40:55]

sdy@chromium.org changed reviewers:
+ rohitrao@chromium.org, sdefresne@chromium.org
- jam@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:46:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sidney San Martín, 2017-01-04 22:02:12]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 22:03:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:14:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sidney San Martín, 2017-01-05 01:55:46]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[Sidney San Martín, 2017-01-05 01:55:58]

The CQ bit was unchecked by sdy@chromium.org

[Sidney San Martín, 2017-01-05 02:02:30]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 02:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sidney San Martín, 2017-01-05 03:08:53]

Description was changed from

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.
==========

to

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Also drop some unnecessary ivar declarations (handled by @synthesize).
==========

[commit-bot: I haz the power, 2017-01-05 03:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:10:16]

Dry run: This issue passed the CQ dry run.

[Sidney San Martín, 2017-01-05 03:24:05]

This CL depends on crrev/2500033002, which introduces a simpler replacement for
ObjCPropertyReleaser. That's still in review, but I wanted to put this one out
too so that you can take a look. Thanks!

Some notes inline, with one question about correctness at the end.

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/h...
File ios/chrome/browser/ui/history/history_entry_item.mm (left):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/h...
ios/chrome/browser/ui/history/history_entry_item.mm:231: @property(nonatomic,
readwrite, retain) UILabel* timeLabel;
This pattern of redeclaring properties as readwrite shows up in a few places. I
don't think it's necessary with the new implementation, but I added a test to
make sure.

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/new_tab_page_bar.h (right):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/new_tab_page_bar.h:31: @property(nonatomic, readonly,
retain) NSArray* buttons;  // UIButton
I moved these comments from the ivar declarations in the next file, but I'd be
just as happy to remove them.

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h (right):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h:26: // New tab page view.
Same for these comments.

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/new_tab_page_view.h (right):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/new_tab_page_view.h:16: @property(nonatomic, assign,
readonly) NewTabPageBar* tabBar;
Is this change correct? The compiler won't synthesize these ivars when they're
declared as weak, since the file isn't compiled with ARC. I'd be fine with
changing it back, since cleaning up ivars is secondary.

[Sidney San Martín, 2017-01-05 03:25:59]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 03:26:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 04:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 04:32:18]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2017-01-05 10:02:51]

noyau@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2017-01-05 10:02:52]

I'd rather see all all those uses of property releaser removed and the files
compiled with ARC... A third of the ios ObjectiveC files have been converted
already, let me know if you want to help with this effort instead :)

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/h...
File ios/chrome/browser/ui/history/history_entry_item.mm (left):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/h...
ios/chrome/browser/ui/history/history_entry_item.mm:231: @property(nonatomic,
readwrite, retain) UILabel* timeLabel;
On 2017/01/05 03:24:05, sdy wrote:
> This pattern of redeclaring properties as readwrite shows up in a few places.
I
> don't think it's necessary with the new implementation, but I added a test to
> make sure.

At some point the property releaser had a bug (inherited from the objc runtime)
where readonly properties were not enumerated properly, and as such not released
by the property releaser. Redeclaration for those is no longer necessary.

But there are some cases where the public API is a readonly property, but from
within the class itself it is redeclared as readwrite for cleaner code. Those
need to stay as the code would not compile without it.

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/new_tab_page_view.h (right):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/new_tab_page_view.h:16: @property(nonatomic, assign,
readonly) NewTabPageBar* tabBar;
On 2017/01/05 03:24:05, sdy wrote:
> Is this change correct? The compiler won't synthesize these ivars when they're
> declared as weak, since the file isn't compiled with ARC. I'd be fine with
> changing it back, since cleaning up ivars is secondary.

I'm confused by your statement. There is an explicit @synthetize for these
property in the .mm, why would you think those would not work?

[Sidney San Martín, 2017-01-05 19:04:25]

On 2017/01/05 10:02:52, noyau wrote:
> I'd rather see all all those uses of property releaser removed and the files
> compiled with ARC... A third of the ios ObjectiveC files have been converted
> already, let me know if you want to help with this effort instead :)

I'm in favor of ARC, but I work on Mac and we don't have any plans to adopt it
in our code right now. Switching everything to ReleaseProperties didn't take too
long and would let me delete ObjCPropertyReleaser right away rather than wait
until iOS is fully ARC. Does that seem reasonable? I don't have spare cycles to
help with the conversion, but if you think it's better to keep
ObjCPropertyReleaser around rather than touching these files, that might be OK.

> At some point the property releaser had a bug (inherited from the objc
runtime)
> where readonly properties were not enumerated properly, and as such not
released
> by the property releaser. Redeclaration for those is no longer necessary.

Interesting, thanks!

> I'm confused by your statement. There is an explicit @synthetize for these
> property in the .mm, why would you think those would not work?

I agree that it's confusing — after I deleted the block of ivars in
new_tab_page_view.mm, the build failed with this error:

    ../../ios/chrome/browser/ui/ntp/new_tab_page_view.mm:16:13: error: cannot
synthesize weak property in file using manual reference counting
    @synthesize scrollView = scrollView_;

[noyau (Ping after 24h), 2017-01-06 14:05:20]

On 2017/01/05 19:04:25, sdy wrote:
> On 2017/01/05 10:02:52, noyau wrote:
> > I'd rather see all all those uses of property releaser removed and the files
> > compiled with ARC... A third of the ios ObjectiveC files have been converted
> > already, let me know if you want to help with this effort instead :)
> 
> I'm in favor of ARC, but I work on Mac and we don't have any plans to adopt it
> in our code right now. Switching everything to ReleaseProperties didn't take
too
> long and would let me delete ObjCPropertyReleaser right away rather than wait
> until iOS is fully ARC. Does that seem reasonable? I don't have spare cycles
to
> help with the conversion, but if you think it's better to keep
> ObjCPropertyReleaser around rather than touching these files, that might be
OK.
> 
Ack. This code is orthogonal to the ARC effort and makes ARC conversion easier
(just remove the dealloc method, and in most case it's done!) so definitely
check it in.

But please don't remove the ObjCPropertyReleaser right away once you land the
new function. Leave both in and synchronize with rohitrao, sdefresne of me to
apply the change to what's left of our private repository. Thanks.

[noyau (Ping after 24h), 2017-01-06 14:21:06]

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
File ios/chrome/browser/ui/ntp/new_tab_page_view.h (right):

https://codereview.chromium.org/2610923005/diff/60001/ios/chrome/browser/ui/n...
ios/chrome/browser/ui/ntp/new_tab_page_view.h:16: @property(nonatomic, assign,
readonly) NewTabPageBar* tabBar;
On 2017/01/05 10:02:52, noyau wrote:
> On 2017/01/05 03:24:05, sdy wrote:
> > Is this change correct? The compiler won't synthesize these ivars when
they're
> > declared as weak, since the file isn't compiled with ARC. I'd be fine with
> > changing it back, since cleaning up ivars is secondary.
> 
> I'm confused by your statement. There is an explicit @synthetize for these
> property in the .mm, why would you think those would not work?

Ok. for MRR assign is correct and weak is incorrect (as the instance variables
were markes unsafe_unretained). Your change is correct.

[noyau (Ping after 24h), 2017-02-03 13:01:28]

Any progress there? I like this CL, this simplifies code… Sylvain, Rohit, why no
lgtm here?

[Sidney San Martín, 2017-02-03 17:17:52]

On 2017/02/03 13:01:28, noyau wrote:
> Any progress there? I like this CL, this simplifies code… Sylvain, Rohit, why
no
> lgtm here?

+mark

Just waiting on crrev/2500033002.

[Sidney San Martín, 2017-02-13 21:25:56]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 21:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 21:37:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sidney San Martín, 2017-02-14 00:30:28]

Description was changed from

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Also drop some unnecessary ivar declarations (handled by @synthesize).
==========

to

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.
==========

[Sidney San Martín, 2017-02-14 00:31:03]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 00:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 00:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:59:36]

Dry run: This issue passed the CQ dry run.

[Sidney San Martín, 2017-02-14 02:03:08]

sdefresne, rohitrao: PTAL

[sdefresne, 2017-02-14 12:22:36]

On 2017/02/14 02:03:08, sdy wrote:
> sdefresne, rohitrao: PTAL

I'm undecided on this. Technically this LG.

However, we are migrating to ARC. As part of the conversion, we are removing all
ObjCPropertyReleaser (because they do not work with ARC so we have compilation
errors). It looks like the new ReleaseProperties function will work with ARC,
which mean that we need to tech reviewers and people doing the conversion to
look for those function call and remove them if they exists. So, it mean that if
we land this CL we may forget to remove the calls to ReleaseProperties while
doing the conversion to ARC.

[Sidney San Martín, 2017-02-14 16:16:22]

On 2017/02/14 12:22:36, sdefresne wrote:
> On 2017/02/14 02:03:08, sdy wrote:
> > sdefresne, rohitrao: PTAL
> 
> I'm undecided on this. Technically this LG.
> 
> However, we are migrating to ARC. As part of the conversion, we are removing
all
> ObjCPropertyReleaser (because they do not work with ARC so we have compilation
> errors). It looks like the new ReleaseProperties function will work with ARC,
> which mean that we need to tech reviewers and people doing the conversion to
> look for those function call and remove them if they exists. So, it mean that
if
> we land this CL we may forget to remove the calls to ReleaseProperties while
> doing the conversion to ARC.

The ReleaseProperties header #errors if it's built with ARC:

https://chromium.googlesource.com/chromium/src/+/10596b3f04f72a63151cd1687fce...

Looking at it now, I think the message could be better, but I think it takes
care of this concern.

[sdefresne, 2017-02-14 16:34:26]

lgtm

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
ios/chrome/browser/payments/payment_request_coordinator.mm:48: if ((self =
[super initWithBaseViewController:baseViewController])) {
Looks like this is now just calling super -initWithBaseViewController:, so maybe
remove?

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm:17: -
(instancetype)init {
This just call super -init, remove.

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm:10: #include
"base/mac/objc_release_properties.h"
Remove.

[Sidney San Martín, 2017-02-14 21:32:12]

Patchset #8 (id:140001) has been deleted

[Sidney San Martín, 2017-02-14 21:38:15]

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
ios/chrome/browser/payments/payment_request_coordinator.mm:48: if ((self =
[super initWithBaseViewController:baseViewController])) {
On 2017/02/14 16:34:26, sdefresne wrote:
> Looks like this is now just calling super -initWithBaseViewController:, so
maybe
> remove?

Done, thanks. When I initially tried to remove this, I got a diagnostic from
-Wobjc-designated-initializers. I could've sworn I saw other examples of empty
init overrides in the iOS codebase, so I left it. However, I now think that's
just because it's redeclared in payment_request_coordinator.h. I deleted it, but
I'm not sure if the comment in the .h was worth preserving. What do you think?

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm:17: -
(instancetype)init {
On 2017/02/14 16:34:26, sdefresne wrote:
> This just call super -init, remove.

Done.

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm (right):

https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm:10: #include
"base/mac/objc_release_properties.h"
On 2017/02/14 16:34:26, sdefresne wrote:
> Remove.

Done.

[Sidney San Martín, 2017-02-15 05:53:29]

The CQ bit was checked by sdy@chromium.org

[Sidney San Martín, 2017-02-15 05:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2610923005/#ps160001
(title: "Dead code.")

[commit-bot: I haz the power, 2017-02-15 05:54:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 06:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 06:06:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sidney San Martín, 2017-02-15 06:08:33]

On 2017/02/15 06:06:29, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Sorry, forgot to wait on Rohit for OWNERship.

[sdefresne, 2017-02-15 10:35:29]

On 2017/02/14 21:38:15, sdy wrote:
>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
> File ios/chrome/browser/payments/payment_request_coordinator.mm (right):
> 
>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/pay...
> ios/chrome/browser/payments/payment_request_coordinator.mm:48: if ((self =
> [super initWithBaseViewController:baseViewController])) {
> On 2017/02/14 16:34:26, sdefresne wrote:
> > Looks like this is now just calling super -initWithBaseViewController:, so
> maybe
> > remove?
> 
> Done, thanks. When I initially tried to remove this, I got a diagnostic from
> -Wobjc-designated-initializers. I could've sworn I saw other examples of empty
> init overrides in the iOS codebase, so I left it. However, I now think that's
> just because it's redeclared in payment_request_coordinator.h. I deleted it,
but
> I'm not sure if the comment in the .h was worth preserving. What do you think?

If this is the case, I think we can remove the declaration for the initialiser
from payment_request_coordinator.h and the associated comment (the class comment
already says that). If you change the header file, can you take the opportunity
to unabbreviate PR in the class comment?

So change it from:

// Coordinator responsible for creating and presenting the PaymentRequest view
// controller. The PR view controller will be presented by the view controller
// provided in the initializer.

to

// Coordinator responsible for creating and presenting the PaymentRequest view
// controller. The PaymentRequest view controller will be presented by the view
// controller provided in the initializer.


>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
> File ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm (right):
> 
>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
> ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm:17: -
> (instancetype)init {
> On 2017/02/14 16:34:26, sdefresne wrote:
> > This just call super -init, remove.
> 
> Done.
> 
>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
> File ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm (right):
> 
>
https://codereview.chromium.org/2610923005/diff/120001/ios/chrome/browser/ui/...
> ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm:10: #include
> "base/mac/objc_release_properties.h"
> On 2017/02/14 16:34:26, sdefresne wrote:
> > Remove.
> 
> Done.

[Sidney San Martín, 2017-02-15 15:21:42]

On 2017/02/15 10:35:29, sdefresne wrote:
> If this is the case, I think we can remove the declaration for the initialiser
> from payment_request_coordinator.h and the associated comment (the class
comment
> already says that). If you change the header file, can you take the
opportunity
> to unabbreviate PR in the class comment?
> 
> So change it from:
> 
> // Coordinator responsible for creating and presenting the PaymentRequest view
> // controller. The PR view controller will be presented by the view controller
> // provided in the initializer.
> 
> to
> 
> // Coordinator responsible for creating and presenting the PaymentRequest view
> // controller. The PaymentRequest view controller will be presented by the
view
> // controller provided in the initializer.

Sure, done.

[noyau (Ping after 24h), 2017-04-28 08:22:16]

Removing myself as reviewer. I like this CL, but it's not moving.

[noyau (Ping after 24h), 2017-04-28 08:23:22]

noyau@chromium.org changed reviewers:
- noyau@chromium.org

[Sidney San Martín, 2017-05-12 22:54:08]

The CQ bit was checked by sdy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 22:54:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:41:30]

Dry run: This issue passed the CQ dry run.

[Sidney San Martín, 2017-05-12 23:50:28]

rohitrao@ — PTAL?

[rohitrao (ping after 24h), 2017-05-15 12:33:28]

lgtm

[Sidney San Martín, 2017-05-15 13:50:42]

The CQ bit was checked by sdy@chromium.org

[Sidney San Martín, 2017-05-15 13:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2610923005/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-15 13:51:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 14:38:00]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494856242032010,
"parent_rev": "972a223f732b820c143a53c9e83c90b52b9c8369", "commit_rev":
"6c018d86b723aee46a2f80cf403a3fabc3bbd7a1"}

[commit-bot: I haz the power, 2017-05-15 14:38:13]

Description was changed from

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.
==========

to

==========
Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Review-Url: https://codereview.chromium.org/2610923005
Cr-Commit-Position: refs/heads/master@{#471754}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c018d86b723aee46a2f80cf403a...
==========

[commit-bot: I haz the power, 2017-05-15 14:38:15]

Committed patchset #10 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/6c018d86b723aee46a2f80cf403a...

[huangml, 2017-05-15 18:10:25]

A revert of this CL (patchset #10 id:200001) has been created in
https://codereview.chromium.org/2881183002/ by huangml@google.com.

The reason for reverting is: Revert the CL as some iOS tests are failing due to
releasing issues.

https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27565.