Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
index 182983a755e020df31c48d51793426f09d957416..9db0a61675baa70ebb7f58b333dc722caa7d342d 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h"
#include "base/i18n/rtl.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
#include "ui/base/l10n/l10n_util.h"
@@ -16,7 +16,9 @@
static NSString* const kMenuItemCellID = @"MenuItemCellID";
}
-@implementation ToolsMenuViewItem
+@implementation ToolsMenuViewItem {
+ base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewItem;
+}
@synthesize accessibilityIdentifier = _accessibilityIdentifier;
@synthesize active = _active;
@@ -27,15 +29,11 @@
- (id)init {
self = [super init];
if (self) {
+ _propertyReleaser_ToolsMenuViewItem.Init(self, [ToolsMenuViewItem class]);
_active = YES;
}
return self;
-}
-
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
}
+ (NSString*)cellID {
@@ -60,7 +58,9 @@
@end
-@implementation ToolsMenuViewCell
+@implementation ToolsMenuViewCell {
+ base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewCell;
+}
@synthesize title = _title;
@synthesize horizontalMargin = _horizontalMargin;
@@ -82,15 +82,11 @@
}
- (void)commonInitialization {
+ _propertyReleaser_ToolsMenuViewCell.Init(self, [ToolsMenuViewCell class]);
_horizontalMargin = !base::i18n::IsRTL() ? kToolsMenuItemHorizontalMargin
: kToolsMenuItemHorizontalMarginRTL;
[self setBackgroundColor:[UIColor whiteColor]];
[self setOpaque:YES];
-}
-
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
}
- (void)prepareForReuse {

Powered by Google App Engine
This is Rietveld 408576698