Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm b/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
index adbdd0a76b304b982f6ab3bcddda04ce9f848951..d259ef5d9be69ea1c14677bc71012b43c13a270a 100644
--- a/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
@@ -7,7 +7,7 @@
#include "base/ios/ios_util.h"
#include "base/logging.h"
#import "base/mac/foundation_util.h"
-#import "base/mac/objc_release_properties.h"
+#import "base/mac/objc_property_releaser.h"
#import "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
@@ -39,15 +39,22 @@
SavedBarButtomItemPositionEnum savedBarButtonItemPosition_;
base::scoped_nsobject<UIBarButtonItem> savedBarButtonItem_;
base::scoped_nsobject<UIView> veil_;
+
+ base::mac::ObjCPropertyReleaser
+ propertyReleaser_SettingsRootCollectionViewController_;
}
@synthesize shouldHideDoneButton = shouldHideDoneButton_;
@synthesize collectionViewAccessibilityIdentifier =
collectionViewAccessibilityIdentifier_;
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
+- (instancetype)initWithStyle:(CollectionViewControllerStyle)style {
+ self = [super initWithStyle:style];
+ if (self) {
+ propertyReleaser_SettingsRootCollectionViewController_.Init(
+ self, [SettingsRootCollectionViewController class]);
+ }
+ return self;
}
- (void)viewDidLoad {

Powered by Google App Engine
This is Rietveld 408576698