Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ios/chrome/browser/ui/tabs/tab_view.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tabs/tab_view.mm
diff --git a/ios/chrome/browser/ui/tabs/tab_view.mm b/ios/chrome/browser/ui/tabs/tab_view.mm
index 00a55020f8caffd31e1db7898471c9bab6eeebe9..cbc9b1074cb89658030c90abd64ac4923390513a 100644
--- a/ios/chrome/browser/ui/tabs/tab_view.mm
+++ b/ios/chrome/browser/ui/tabs/tab_view.mm
@@ -8,7 +8,7 @@
#include "base/i18n/rtl.h"
#include "base/ios/ios_util.h"
#include "base/logging.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#include "base/strings/sys_string_conversions.h"
#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
@@ -72,6 +72,8 @@
BOOL _collapsed;
base::scoped_nsobject<MDCActivityIndicator> _activityIndicator;
+
+ base::mac::ObjCPropertyReleaser _propertyReleaser_TabView;
}
@end
@@ -113,6 +115,7 @@
- (id)initWithEmptyView:(BOOL)emptyView selected:(BOOL)selected {
if ((self = [super initWithFrame:CGRectZero])) {
+ _propertyReleaser_TabView.Init(self, [TabView class]);
[self setOpaque:NO];
[self createCommonViews];
// -setSelected only calls -updateBackgroundImage if the selected state
@@ -125,11 +128,6 @@
[self createButtonsAndLabel];
}
return self;
-}
-
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
}
- (void)setSelected:(BOOL)selected {
« no previous file with comments | « ios/chrome/browser/ui/tabs/tab_strip_controller.mm ('k') | ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698