Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: ios/chrome/browser/ui/tabs/tab_strip_controller.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/stack_view/stack_view_controller.mm ('k') | ios/chrome/browser/ui/tabs/tab_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/tabs/tab_strip_controller.mm
diff --git a/ios/chrome/browser/ui/tabs/tab_strip_controller.mm b/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
index 7f3f0c4eac27821d3d5a78ad052eada0ffa5b495..c09b68a369b2f3dce5afbcc304cdb4f01116fcdc 100644
--- a/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
+++ b/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
@@ -12,7 +12,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -183,6 +183,8 @@
// The model index of the placeholder gap, if one exists. This value is used
// as the new model index of the dragged tab when it is dropped.
NSUInteger _placeholderGapModelIndex;
+
+ base::mac::ObjCPropertyReleaser _propertyReleaser_TabStripController;
}
@property(nonatomic, readonly, retain) TabStripView* tabStripView;
@@ -324,6 +326,7 @@
- (instancetype)initWithTabModel:(TabModel*)tabModel
style:(TabStrip::Style)style {
if ((self = [super init])) {
+ _propertyReleaser_TabStripController.Init(self, [TabStripController class]);
_tabArray.reset([[NSMutableArray alloc] initWithCapacity:10]);
_closingTabs.reset([[NSMutableSet alloc] initWithCapacity:5]);
@@ -429,7 +432,6 @@
[_tabStripView setDelegate:nil];
[_tabStripView setLayoutDelegate:nil];
[_tabModel removeObserver:self];
- base::mac::ReleaseProperties(self);
[super dealloc];
}
« no previous file with comments | « ios/chrome/browser/ui/stack_view/stack_view_controller.mm ('k') | ios/chrome/browser/ui/tabs/tab_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698