Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm
diff --git a/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm b/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm
index 5d528dfaf144bcc299db22da8a9180bf29a8df28..67844336d01c4c046bc9a25e4611011b1cfdf012 100644
--- a/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm
+++ b/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm
@@ -7,7 +7,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
#include "base/mac/bundle_locations.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#import "ios/chrome/browser/ui/animation_util.h"
#import "ios/chrome/browser/ui/popup_menu/popup_menu_view.h"
#include "ios/chrome/browser/ui/rtl_geometry.h"
@@ -55,6 +55,7 @@
} // anonymous namespace
@interface PopupMenuController ()<PopupMenuViewDelegate> {
+ base::mac::ObjCPropertyReleaser propertyReleaser_PopupMenuController_;
CGPoint sourceAnimationPoint_;
}
@end
@@ -84,6 +85,9 @@
DCHECK(parent);
self = [super init];
if (self) {
+ propertyReleaser_PopupMenuController_.Init(self,
+ [PopupMenuController class]);
+
popupContainer_ = [[PopupMenuView alloc]
initWithFrame:CGRectMake(0, 0, kPopupContainerWidth,
kPopupContainerHeight)];
@@ -172,7 +176,6 @@
[popupContainer_ removeFromSuperview];
[backgroundButton_ removeFromSuperview];
[containerView_ removeFromSuperview];
- base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698