Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_view.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/new_tab_page_view.mm
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_view.mm b/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
index 95996a55ffdcf6f43bfb1db5e29e2710f3f87aa9..5245ee5894f6f8217b6a0f9fed9161bb52973cc3 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/ntp/new_tab_page_view.h"
#include "base/logging.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
@@ -17,6 +17,8 @@
// subviews already.
__unsafe_unretained NewTabPageBar* tabBar_; // weak
__unsafe_unretained UIScrollView* scrollView_; // weak
+
+ base::mac::ObjCPropertyReleaser propertyReleaser_NewTabPageView_;
}
@synthesize scrollView = scrollView_;
@@ -27,6 +29,7 @@
andTabBar:(NewTabPageBar*)tabBar {
self = [super initWithFrame:frame];
if (self) {
+ propertyReleaser_NewTabPageView_.Init(self, [NewTabPageView class]);
[self addSubview:scrollView];
[self addSubview:tabBar];
scrollView_ = scrollView;
@@ -43,11 +46,6 @@
- (instancetype)initWithCoder:(NSCoder*)aDecoder {
NOTREACHED();
return nil;
-}
-
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
}
- (void)setFrame:(CGRect)frame {

Powered by Google App Engine
This is Rietveld 408576698