Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_controller.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/stack_view/card_view.mm ('k') | ios/chrome/browser/ui/tabs/tab_strip_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/stack_view/stack_view_controller.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
index d17b5d6ff88da09831629c0216def74db8ad7e53..cdb4ba2b667ddd566f64f01b38844dd897bdc29d 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
@@ -16,7 +16,7 @@
#include "base/logging.h"
#import "base/mac/bundle_locations.h"
#import "base/mac/foundation_util.h"
-#include "base/mac/objc_release_properties.h"
+#import "base/mac/objc_property_releaser.h"
#include "base/mac/scoped_block.h"
#import "base/mac/scoped_nsobject.h"
#include "base/metrics/histogram_macros.h"
@@ -489,6 +489,8 @@
// |YES| if there is card set animation being processed. For testing only.
// Save last touch point used by new tab animation.
CGPoint _lastTapPoint;
+
+ base::mac::ObjCPropertyReleaser _propertyReleaserStackViewController;
}
@synthesize activeCardSet = _activeCardSet;
@@ -511,6 +513,8 @@
DCHECK(activeCardSet == otrCardSet || activeCardSet == mainCardSet);
self = [super initWithNibName:nil bundle:nil];
if (self) {
+ _propertyReleaserStackViewController.Init(self,
+ [StackViewController class]);
[self setUpWithMainCardSet:mainCardSet
otrCardSet:otrCardSet
activeCardSet:activeCardSet];
@@ -812,7 +816,6 @@
[_mainCardSet setObserver:nil];
[_otrCardSet setObserver:nil];
[self cleanUpViewsAndNotifications];
- base::mac::ReleaseProperties(self);
[super dealloc];
}
« no previous file with comments | « ios/chrome/browser/ui/stack_view/card_view.mm ('k') | ios/chrome/browser/ui/tabs/tab_strip_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698