Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, tommycli
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove rendundant WebLocalFrame parameter in various plugin code. Plugin code all over pass around a RenderFrame and a WebLocalFrame, but the RenderFrame parameter already knows about the associated WebLocalFrame. Review-Url: https://codereview.chromium.org/2855123003 Cr-Commit-Position: refs/heads/master@{#469746} Committed: https://chromium.googlesource.com/chromium/src/+/f7d2fa11695bb0cf4a1e1b4a1a62b23c6e154236

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Fix tests #

Patch Set 4 : Fix extensions #

Patch Set 5 : Fix Android #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -211 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 8 chunks +25 lines, -22 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 10 chunks +18 lines, -24 lines 0 comments Download
M chrome/renderer/plugins/non_loadable_plugin_placeholder.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/non_loadable_plugin_placeholder.cc View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/plugins/plugin_preroller.h View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/renderer/plugins/plugin_preroller.cc View 3 chunks +1 line, -3 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.h View 4 chunks +3 lines, -8 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +19 lines, -23 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M content/shell/test_runner/test_plugin.h View 1 4 chunks +2 lines, -7 lines 0 comments Download
M content/shell/test_runner/test_plugin.cc View 1 4 chunks +4 lines, -9 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/test_runner/web_frame_test_proxy.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/test_runner/web_test_delegate.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FakeWebPlugin.h View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FakeWebPlugin.cpp View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 7 chunks +18 lines, -25 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 9 chunks +13 lines, -15 lines 2 comments Download

Messages

Total messages: 34 (26 generated)
Lei Zhang
3 years, 7 months ago (2017-05-04 07:32:55 UTC) #23
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-04 09:34:08 UTC) #24
Lei Zhang
Adding more reviewers for OWNERS: jochen: content/ and third_party/WebKit/ michaelpg: extensions/
3 years, 7 months ago (2017-05-04 20:49:03 UTC) #26
michaelpg
lgtm
3 years, 7 months ago (2017-05-04 22:15:44 UTC) #27
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2855123003/diff/80001/third_party/WebKit/public/web/WebFrameClient.h File third_party/WebKit/public/web/WebFrameClient.h (right): https://codereview.chromium.org/2855123003/diff/80001/third_party/WebKit/public/web/WebFrameClient.h#newcode129 third_party/WebKit/public/web/WebFrameClient.h:129: return nullptr; nit. adding many but unrelated style ...
3 years, 7 months ago (2017-05-05 14:32:40 UTC) #28
Lei Zhang
https://codereview.chromium.org/2855123003/diff/80001/third_party/WebKit/public/web/WebFrameClient.h File third_party/WebKit/public/web/WebFrameClient.h (right): https://codereview.chromium.org/2855123003/diff/80001/third_party/WebKit/public/web/WebFrameClient.h#newcode129 third_party/WebKit/public/web/WebFrameClient.h:129: return nullptr; On 2017/05/05 14:32:40, jochen wrote: > nit. ...
3 years, 7 months ago (2017-05-05 17:18:29 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855123003/80001
3 years, 7 months ago (2017-05-05 17:19:08 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 19:12:11 UTC) #34
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f7d2fa11695bb0cf4a1e1b4a1a62...

Powered by Google App Engine
This is Rietveld 408576698