Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/shell/test_runner/test_plugin.cc

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/test_runner/test_plugin.cc
diff --git a/content/shell/test_runner/test_plugin.cc b/content/shell/test_runner/test_plugin.cc
index c2b5fe63f168c7a426b828ce3b2372c79a258fc2..959439f433cd46398d50ceccba789b49e934e2d7 100644
--- a/content/shell/test_runner/test_plugin.cc
+++ b/content/shell/test_runner/test_plugin.cc
@@ -30,7 +30,6 @@
#include "third_party/WebKit/public/platform/WebTouchPoint.h"
#include "third_party/WebKit/public/platform/WebTraceLocation.h"
#include "third_party/WebKit/public/platform/WebURL.h"
-#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebKit.h"
#include "third_party/WebKit/public/web/WebPluginParams.h"
#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
@@ -110,11 +109,9 @@ blink::WebPluginContainer::TouchEventRequestType ParseTouchEventRequestType(
} // namespace
-TestPlugin::TestPlugin(blink::WebFrame* frame,
- const blink::WebPluginParams& params,
+TestPlugin::TestPlugin(const blink::WebPluginParams& params,
WebTestDelegate* delegate)
- : frame_(frame),
- delegate_(delegate),
+ : delegate_(delegate),
container_(nullptr),
gl_(nullptr),
color_texture_(0),
@@ -212,7 +209,6 @@ void TestPlugin::Destroy() {
context_provider_.reset();
container_ = nullptr;
- frame_ = nullptr;
blink::Platform::Current()
->MainThread()
@@ -587,10 +583,9 @@ bool TestPlugin::HandleDragStatusUpdate(
return false;
}
-TestPlugin* TestPlugin::create(blink::WebFrame* frame,
- const blink::WebPluginParams& params,
+TestPlugin* TestPlugin::Create(const blink::WebPluginParams& params,
WebTestDelegate* delegate) {
- return new TestPlugin(frame, params, delegate);
+ return new TestPlugin(params, delegate);
}
const blink::WebString& TestPlugin::MimeType() {

Powered by Google App Engine
This is Rietveld 408576698