Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_ 5 #ifndef CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_
6 #define CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_ 6 #define CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 10
(...skipping 10 matching lines...) Expand all
21 class ChromePluginPlaceholder final 21 class ChromePluginPlaceholder final
22 : public plugins::LoadablePluginPlaceholder, 22 : public plugins::LoadablePluginPlaceholder,
23 public content::RenderThreadObserver, 23 public content::RenderThreadObserver,
24 public content::ContextMenuClient, 24 public content::ContextMenuClient,
25 public gin::Wrappable<ChromePluginPlaceholder> { 25 public gin::Wrappable<ChromePluginPlaceholder> {
26 public: 26 public:
27 static gin::WrapperInfo kWrapperInfo; 27 static gin::WrapperInfo kWrapperInfo;
28 28
29 static ChromePluginPlaceholder* CreateBlockedPlugin( 29 static ChromePluginPlaceholder* CreateBlockedPlugin(
30 content::RenderFrame* render_frame, 30 content::RenderFrame* render_frame,
31 blink::WebLocalFrame* frame,
32 const blink::WebPluginParams& params, 31 const blink::WebPluginParams& params,
33 const content::WebPluginInfo& info, 32 const content::WebPluginInfo& info,
34 const std::string& identifier, 33 const std::string& identifier,
35 const base::string16& name, 34 const base::string16& name,
36 int resource_id, 35 int resource_id,
37 const base::string16& message, 36 const base::string16& message,
38 const PowerSaverInfo& power_saver_info); 37 const PowerSaverInfo& power_saver_info);
39 38
40 // Creates a new WebViewPlugin with a MissingPlugin as a delegate. 39 // Creates a new WebViewPlugin with a MissingPlugin as a delegate.
41 static ChromePluginPlaceholder* CreateLoadableMissingPlugin( 40 static ChromePluginPlaceholder* CreateLoadableMissingPlugin(
42 content::RenderFrame* render_frame, 41 content::RenderFrame* render_frame,
43 blink::WebLocalFrame* frame,
44 const blink::WebPluginParams& params); 42 const blink::WebPluginParams& params);
45 43
46 void SetStatus(ChromeViewHostMsg_GetPluginInfo_Status status); 44 void SetStatus(ChromeViewHostMsg_GetPluginInfo_Status status);
47 45
48 int32_t CreateRoutingId(); 46 int32_t CreateRoutingId();
49 47
50 private: 48 private:
51 ChromePluginPlaceholder(content::RenderFrame* render_frame, 49 ChromePluginPlaceholder(content::RenderFrame* render_frame,
52 blink::WebLocalFrame* frame,
53 const blink::WebPluginParams& params, 50 const blink::WebPluginParams& params,
54 const std::string& html_data, 51 const std::string& html_data,
55 const base::string16& title); 52 const base::string16& title);
56 ~ChromePluginPlaceholder() override; 53 ~ChromePluginPlaceholder() override;
57 54
58 // content::LoadablePluginPlaceholder overrides. 55 // content::LoadablePluginPlaceholder overrides.
59 blink::WebPlugin* CreatePlugin() override; 56 blink::WebPlugin* CreatePlugin() override;
60 void OnBlockedTinyContent() override; 57 void OnBlockedTinyContent() override;
61 58
62 // gin::Wrappable (via PluginPlaceholder) method 59 // gin::Wrappable (via PluginPlaceholder) method
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 94
98 int context_menu_request_id_; // Nonzero when request pending. 95 int context_menu_request_id_; // Nonzero when request pending.
99 base::string16 plugin_name_; 96 base::string16 plugin_name_;
100 97
101 bool did_send_blocked_content_notification_; 98 bool did_send_blocked_content_notification_;
102 99
103 DISALLOW_COPY_AND_ASSIGN(ChromePluginPlaceholder); 100 DISALLOW_COPY_AND_ASSIGN(ChromePluginPlaceholder);
104 }; 101 };
105 102
106 #endif // CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_ 103 #endif // CHROME_RENDERER_PLUGINS_CHROME_PLUGIN_PLACEHOLDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698