Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: content/shell/test_runner/test_plugin.h

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/test_runner/test_plugin.h
diff --git a/content/shell/test_runner/test_plugin.h b/content/shell/test_runner/test_plugin.h
index 7f7e70666e4ecda3e6cafa4708880947a9749789..07a7a3259bbd10632850f365d69de9bd5a5d8250 100644
--- a/content/shell/test_runner/test_plugin.h
+++ b/content/shell/test_runner/test_plugin.h
@@ -19,7 +19,6 @@
#include "third_party/khronos/GLES2/gl2.h"
namespace blink {
-class WebFrame;
class WebGraphicsContext3DProvider;
class WebLayer;
struct WebPluginParams;
@@ -53,8 +52,7 @@ class WebTestDelegate;
// 'accepts-touch' plugin parameter (defaults to false).
class TestPlugin : public blink::WebPlugin, public cc::TextureLayerClient {
public:
- static TestPlugin* create(blink::WebFrame* frame,
- const blink::WebPluginParams& params,
+ static TestPlugin* Create(const blink::WebPluginParams& params,
WebTestDelegate* delegate);
~TestPlugin() override;
@@ -98,9 +96,7 @@ class TestPlugin : public blink::WebPlugin, public cc::TextureLayerClient {
std::unique_ptr<cc::SingleReleaseCallback>* release_callback) override;
private:
- TestPlugin(blink::WebFrame* frame,
- const blink::WebPluginParams& params,
- WebTestDelegate* delegate);
+ TestPlugin(const blink::WebPluginParams& params, WebTestDelegate* delegate);
enum Primitive { PrimitiveNone, PrimitiveTriangle };
@@ -148,7 +144,6 @@ class TestPlugin : public blink::WebPlugin, public cc::TextureLayerClient {
// Functions for drawing scene in Software.
void DrawSceneSoftware(void* memory);
- blink::WebFrame* frame_;
WebTestDelegate* delegate_;
blink::WebPluginContainer* container_;

Powered by Google App Engine
This is Rietveld 408576698