Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: chrome/renderer/plugins/plugin_preroller.h

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/plugin_preroller.h
diff --git a/chrome/renderer/plugins/plugin_preroller.h b/chrome/renderer/plugins/plugin_preroller.h
index 802e9c442eaab88bab5fd4855bee2beb89eee134..c6e8bfb712bb44b3a45e1b1348f3ccbdeebcd201 100644
--- a/chrome/renderer/plugins/plugin_preroller.h
+++ b/chrome/renderer/plugins/plugin_preroller.h
@@ -12,10 +12,6 @@
#include "third_party/WebKit/public/web/WebPluginParams.h"
#include "url/gurl.h"
-namespace blink {
-class WebLocalFrame;
-}
-
class SkBitmap;
// This class manages a plugin briefly for the purposes of keyframe extraction.
@@ -25,9 +21,8 @@ class SkBitmap;
class PluginPreroller : public content::PluginInstanceThrottler::Observer,
public content::RenderFrameObserver {
public:
- // Does not take ownership of either |plugin| or |throttler|.
+ // Does not take ownership of |render_frame|, |plugin|, or |throttler|.
PluginPreroller(content::RenderFrame* render_frame,
- blink::WebLocalFrame* frame,
const blink::WebPluginParams& params,
const content::WebPluginInfo& info,
const std::string& identifier,
@@ -46,7 +41,6 @@ class PluginPreroller : public content::PluginInstanceThrottler::Observer,
// content::RenderFrameObserver implementation.
void OnDestruct() override;
- blink::WebLocalFrame* frame_;
blink::WebPluginParams params_;
content::WebPluginInfo info_;
std::string identifier_;

Powered by Google App Engine
This is Rietveld 408576698