Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: content/shell/test_runner/web_frame_test_client.cc

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/test_runner/web_frame_test_client.h" 5 #include "content/shell/test_runner/web_frame_test_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 } 363 }
364 364
365 void WebFrameTestClient::DidChangeSelection(bool is_empty_callback) { 365 void WebFrameTestClient::DidChangeSelection(bool is_empty_callback) {
366 if (test_runner()->shouldDumpEditingCallbacks()) 366 if (test_runner()->shouldDumpEditingCallbacks())
367 delegate_->PrintMessage( 367 delegate_->PrintMessage(
368 "EDITING DELEGATE: " 368 "EDITING DELEGATE: "
369 "webViewDidChangeSelection:WebViewDidChangeSelectionNotification\n"); 369 "webViewDidChangeSelection:WebViewDidChangeSelectionNotification\n");
370 } 370 }
371 371
372 blink::WebPlugin* WebFrameTestClient::CreatePlugin( 372 blink::WebPlugin* WebFrameTestClient::CreatePlugin(
373 blink::WebLocalFrame* frame,
374 const blink::WebPluginParams& params) { 373 const blink::WebPluginParams& params) {
375 if (TestPlugin::IsSupportedMimeType(params.mime_type)) 374 if (TestPlugin::IsSupportedMimeType(params.mime_type))
376 return TestPlugin::create(frame, params, delegate_); 375 return TestPlugin::Create(params, delegate_);
377 return delegate_->CreatePluginPlaceholder(frame, params); 376 return delegate_->CreatePluginPlaceholder(params);
378 } 377 }
379 378
380 void WebFrameTestClient::ShowContextMenu( 379 void WebFrameTestClient::ShowContextMenu(
381 const blink::WebContextMenuData& context_menu_data) { 380 const blink::WebContextMenuData& context_menu_data) {
382 delegate_->GetWebWidgetTestProxyBase(web_frame_test_proxy_base_->web_frame()) 381 delegate_->GetWebWidgetTestProxyBase(web_frame_test_proxy_base_->web_frame())
383 ->event_sender() 382 ->event_sender()
384 ->SetContextMenuData(context_menu_data); 383 ->SetContextMenuData(context_menu_data);
385 } 384 }
386 385
387 blink::WebUserMediaClient* WebFrameTestClient::UserMediaClient() { 386 blink::WebUserMediaClient* WebFrameTestClient::UserMediaClient() {
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 blink::WebEffectiveConnectionType 737 blink::WebEffectiveConnectionType
739 WebFrameTestClient::GetEffectiveConnectionType() { 738 WebFrameTestClient::GetEffectiveConnectionType() {
740 return test_runner()->effective_connection_type(); 739 return test_runner()->effective_connection_type();
741 } 740 }
742 741
743 TestRunner* WebFrameTestClient::test_runner() { 742 TestRunner* WebFrameTestClient::test_runner() {
744 return web_view_test_proxy_base_->test_interfaces()->GetTestRunner(); 743 return web_view_test_proxy_base_->test_interfaces()->GetTestRunner();
745 } 744 }
746 745
747 } // namespace test_runner 746 } // namespace test_runner
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698