Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp b/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
index fc67ed2cb2beb2ac63ff3f8e320d45f473a0944e..40bf957e929d46f2f430368c06a481f5e58ac8eb 100644
--- a/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
@@ -17,8 +17,8 @@ namespace {
class FakePlaceholderWebPlugin : public FakeWebPlugin {
public:
- FakePlaceholderWebPlugin(WebFrame* frame, const WebPluginParams& params)
- : FakeWebPlugin(frame, params) {}
+ explicit FakePlaceholderWebPlugin(const WebPluginParams& params)
+ : FakeWebPlugin(params) {}
~FakePlaceholderWebPlugin() override {}
bool IsPlaceholder() override { return true; }
@@ -29,10 +29,9 @@ class WebHelperPluginFrameClient : public FrameTestHelpers::TestWebFrameClient {
WebHelperPluginFrameClient() : create_placeholder_(false) {}
~WebHelperPluginFrameClient() override {}
- WebPlugin* CreatePlugin(WebLocalFrame* frame,
- const WebPluginParams& params) override {
- return create_placeholder_ ? new FakePlaceholderWebPlugin(frame, params)
- : new FakeWebPlugin(frame, params);
+ WebPlugin* CreatePlugin(const WebPluginParams& params) override {
+ return create_placeholder_ ? new FakePlaceholderWebPlugin(params)
+ : new FakeWebPlugin(params);
}
void SetCreatePlaceholder(bool create_placeholder) {

Powered by Google App Engine
This is Rietveld 408576698