Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4891)

Unified Diff: chrome/renderer/plugins/non_loadable_plugin_placeholder.cc

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
diff --git a/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc b/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
index 38e4349651bc64b07cbf98ae202cae5b5e6e6729..b6e550a58624484bb88a3063a3407286e73f5ff8 100644
--- a/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
+++ b/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
@@ -21,7 +21,6 @@
plugins::PluginPlaceholder*
NonLoadablePluginPlaceholder::CreateNotSupportedPlugin(
content::RenderFrame* render_frame,
- blink::WebLocalFrame* frame,
const blink::WebPluginParams& params) {
const base::StringPiece template_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(
@@ -34,7 +33,7 @@ NonLoadablePluginPlaceholder::CreateNotSupportedPlugin(
std::string html_data = webui::GetI18nTemplateHtml(template_html, &values);
// PluginPlaceholder will destroy itself when its WebViewPlugin is going away.
- return new plugins::PluginPlaceholder(render_frame, frame, params, html_data);
+ return new plugins::PluginPlaceholder(render_frame, params, html_data);
}
// static
@@ -53,7 +52,7 @@ plugins::PluginPlaceholder* NonLoadablePluginPlaceholder::CreateErrorPlugin(
blink::WebPluginParams params;
// PluginPlaceholder will destroy itself when its WebViewPlugin is going away.
plugins::PluginPlaceholder* plugin =
- new plugins::PluginPlaceholder(render_frame, nullptr, params, html_data);
+ new plugins::PluginPlaceholder(render_frame, params, html_data);
content::RenderThread::Get()->Send(new ChromeViewHostMsg_CouldNotLoadPlugin(
plugin->routing_id(), file_path));

Powered by Google App Engine
This is Rietveld 408576698