Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: components/plugins/renderer/plugin_placeholder.cc

Issue 2855123003: Remove rendundant WebLocalFrame parameter in various plugin code. (Closed)
Patch Set: Fix Android Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/plugin_placeholder.cc
diff --git a/components/plugins/renderer/plugin_placeholder.cc b/components/plugins/renderer/plugin_placeholder.cc
index 8d11e55a934d9c7520a778727cb496998f8ed859..950257531de867f52c3b168cc7abe1d42538c4ce 100644
--- a/components/plugins/renderer/plugin_placeholder.cc
+++ b/components/plugins/renderer/plugin_placeholder.cc
@@ -21,11 +21,9 @@ const char kPluginPlaceholderDataURL[] = "data:text/html,pluginplaceholderdata";
PluginPlaceholderBase::PluginPlaceholderBase(
content::RenderFrame* render_frame,
- blink::WebLocalFrame* frame,
const blink::WebPluginParams& params,
const std::string& html_data)
: content::RenderFrameObserver(render_frame),
- frame_(frame),
plugin_params_(params),
plugin_(WebViewPlugin::Create(render_frame->GetRenderView(),
this,
@@ -113,23 +111,15 @@ void PluginPlaceholderBase::HideCallback() {
HidePlugin();
}
-void PluginPlaceholderBase::OnDestruct() {
- frame_ = NULL;
-}
-
-blink::WebLocalFrame* PluginPlaceholderBase::GetFrame() {
- return frame_;
-}
+void PluginPlaceholderBase::OnDestruct() {}
// static
gin::WrapperInfo PluginPlaceholder::kWrapperInfo = {gin::kEmbedderNativeGin};
PluginPlaceholder::PluginPlaceholder(content::RenderFrame* render_frame,
- blink::WebLocalFrame* frame,
const blink::WebPluginParams& params,
const std::string& html_data)
- : PluginPlaceholderBase(render_frame, frame, params, html_data) {
-}
+ : PluginPlaceholderBase(render_frame, params, html_data) {}
PluginPlaceholder::~PluginPlaceholder() {
}

Powered by Google App Engine
This is Rietveld 408576698