Remove base::Value::Get{Buffer,Size}

Remove base::Value::Get{Buffer,Size}

This change removes the deprecated base::Value::Get{Buffer(),Size()} and
replaces them with base::Value::GetBlob().{data(),size()} while
simplifing the code where appropriate.

BUG=646113
Review-Url: https://codereview.chromium.org/2841623003
Cr-Commit-Position: refs/heads/master@{#467085}
Committed: https://chromium.googlesource.com/chromium/src/+/5328aff0ad17d3d17197c34659d0993cfc77e276

[jdoerrie, 2017-04-24 16:49:25]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 16:49:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-24 16:59:35]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org, rdevlin.cronin@chromium.org, rsesek@chromium.org,
vabr@chromium.org

[jdoerrie, 2017-04-24 16:59:36]

rdevlin.cronin@chromium.org: Please review changes in //tools and //extensions.

brettw@chromium.org: Please review changes in //base.

rsesek@chromium.org: Please review changes in
//mojo/common/values_struct_traits.h

vabr@chromium.org: Please review the remaining files.

[commit-bot: I haz the power, 2017-04-24 18:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:10:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Robert Sesek, 2017-04-24 18:17:02]

LGTM

[Devlin, 2017-04-24 18:18:45]

extensions + tools lgtm

https://codereview.chromium.org/2841623003/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2841623003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:81:
digest->assign(binary_begin, binary_begin + binary->GetBlob().size());
does *digest = binary->GetBlob() work?  Or does a platform compiler complain
about uint8_t vs char?

[vabr (Chromium), 2017-04-25 06:50:24]

On 2017/04/24 16:59:36, jdoerrie wrote:
> mailto:vabr@chromium.org: Please review the remaining files.

LGTM!
Vaclav

[jdoerrie, 2017-04-25 08:46:47]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 08:47:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-25 08:50:34]

https://codereview.chromium.org/2841623003/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2841623003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:81:
digest->assign(binary_begin, binary_begin + binary->GetBlob().size());
On 2017/04/24 18:18:45, Devlin wrote:
> does *digest = binary->GetBlob() work?  Or does a platform compiler complain
> about uint8_t vs char?

Done. I was indeed afraid that the compiler would complain here, but at least
locally it's fine. Let's see what the bots say :)

https://codereview.chromium.org/2841623003/diff/20001/tools/json_schema_compi...
File tools/json_schema_compiler/cc_generator.py (right):

https://codereview.chromium.org/2841623003/diff/20001/tools/json_schema_compi...
tools/json_schema_compiler/cc_generator.py:903: '%(dst_var)s.reset(new
std::vector<char>(%(src_var)s->GetBlob()));')
dst_var might be null, which caused the SIGSEGV on the bots. Do you mind taking
another look at this, rdevlin.cronin@?

[commit-bot: I haz the power, 2017-04-25 10:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 10:09:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdoerrie, 2017-04-25 11:07:47]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 11:07:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-25 11:09:08]

https://codereview.chromium.org/2841623003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2841623003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:79:
*digest = binary->GetBlob();
The linux_chromium_chromeos_* bots complain unfortunately, I will revert this:

.../extensions/api/certificate_provider/certificate_provider_apitest.cc:79:13:
error: no viable overloaded '='
    *digest = binary->GetBlob();
    ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
.../debian_jessie_amd64-sysroot/usr/include/c++/4.8/bits/stl_vector.h:427:7:
note: candidate function not viable: no known conversion from 'const
vector<char, allocator<char>>' to 'const vector<unsigned char,
allocator<unsigned char>>' for 1st argument
      operator=(const vector& __x);

[commit-bot: I haz the power, 2017-04-25 13:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:52:22]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-04-25 15:04:11]

extensions + tools s lgtm

https://codereview.chromium.org/2841623003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2841623003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:79:
*digest = binary->GetBlob();
On 2017/04/25 11:09:08, jdoerrie wrote:
> The linux_chromium_chromeos_* bots complain unfortunately, I will revert this:
> 
> .../extensions/api/certificate_provider/certificate_provider_apitest.cc:79:13:
> error: no viable overloaded '='
>     *digest = binary->GetBlob();
>     ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
> .../debian_jessie_amd64-sysroot/usr/include/c++/4.8/bits/stl_vector.h:427:7:
> note: candidate function not viable: no known conversion from 'const
> vector<char, allocator<char>>' to 'const vector<unsigned char,
> allocator<unsigned char>>' for 1st argument
>       operator=(const vector& __x);

Ah well - worth a shot!

[brettw, 2017-04-25 19:36:31]

lgtm

[jdoerrie, 2017-04-25 19:59:22]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-04-25 19:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2841623003/#ps40001
(title: "std::vector::assign instead of std::vector::operator=")

[commit-bot: I haz the power, 2017-04-25 20:00:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:08:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493150362255970,
"parent_rev": "ef02679eee49f5cf61d435261354cd59504fc781", "commit_rev":
"5328aff0ad17d3d17197c34659d0993cfc77e276"}

[commit-bot: I haz the power, 2017-04-25 20:08:33]

Description was changed from

==========
Remove base::Value::Get{Buffer,Size}

This change removes the deprecated base::Value::Get{Buffer(),Size()} and
replaces them with base::Value::GetBlob().{data(),size()} while
simplifing the code where appropriate.

BUG=646113
==========

to

==========
Remove base::Value::Get{Buffer,Size}

This change removes the deprecated base::Value::Get{Buffer(),Size()} and
replaces them with base::Value::GetBlob().{data(),size()} while
simplifing the code where appropriate.

BUG=646113

Review-Url: https://codereview.chromium.org/2841623003
Cr-Commit-Position: refs/heads/master@{#467085}
Committed:
https://chromium.googlesource.com/chromium/src/+/5328aff0ad17d3d17197c34659d0...
==========

[commit-bot: I haz the power, 2017-04-25 20:08:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5328aff0ad17d3d17197c34659d0...