Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: mojo/common/values_struct_traits.h

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)
Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_COMMON_VALUES_STRUCT_TRAITS_H_ 5 #ifndef MOJO_COMMON_VALUES_STRUCT_TRAITS_H_
6 #define MOJO_COMMON_VALUES_STRUCT_TRAITS_H_ 6 #define MOJO_COMMON_VALUES_STRUCT_TRAITS_H_
7 7
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "mojo/common/values.mojom.h" 9 #include "mojo/common/values.mojom.h"
10 #include "mojo/public/cpp/bindings/array_traits.h" 10 #include "mojo/public/cpp/bindings/array_traits.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 if (!value.GetAsString(&string_piece)) 170 if (!value.GetAsString(&string_piece))
171 NOTREACHED(); 171 NOTREACHED();
172 return string_piece; 172 return string_piece;
173 } 173 }
174 174
175 static mojo::ConstCArray<uint8_t> binary_value(const base::Value& value) { 175 static mojo::ConstCArray<uint8_t> binary_value(const base::Value& value) {
176 const base::Value* binary_value = nullptr; 176 const base::Value* binary_value = nullptr;
177 if (!value.GetAsBinary(&binary_value)) 177 if (!value.GetAsBinary(&binary_value))
178 NOTREACHED(); 178 NOTREACHED();
179 return mojo::ConstCArray<uint8_t>( 179 return mojo::ConstCArray<uint8_t>(
180 binary_value->GetSize(), 180 binary_value->GetBlob().size(),
181 reinterpret_cast<const uint8_t*>(binary_value->GetBuffer())); 181 reinterpret_cast<const uint8_t*>(binary_value->GetBlob().data()));
182 } 182 }
183 183
184 static const base::ListValue& list_value(const base::Value& value) { 184 static const base::ListValue& list_value(const base::Value& value) {
185 const base::ListValue* list_value = nullptr; 185 const base::ListValue* list_value = nullptr;
186 if (!value.GetAsList(&list_value)) 186 if (!value.GetAsList(&list_value))
187 NOTREACHED(); 187 NOTREACHED();
188 return *list_value; 188 return *list_value;
189 } 189 }
190 static const base::DictionaryValue& dictionary_value( 190 static const base::DictionaryValue& dictionary_value(
191 const base::Value& value) { 191 const base::Value& value) {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 base::Value>::dictionary_value(*value); 248 base::Value>::dictionary_value(*value);
249 } 249 }
250 250
251 static bool Read(common::mojom::ValueDataView data, 251 static bool Read(common::mojom::ValueDataView data,
252 std::unique_ptr<base::Value>* value); 252 std::unique_ptr<base::Value>* value);
253 }; 253 };
254 254
255 } // namespace mojo 255 } // namespace mojo
256 256
257 #endif // MOJO_COMMON_VALUES_STRUCT_TRAITS_H_ 257 #endif // MOJO_COMMON_VALUES_STRUCT_TRAITS_H_
OLDNEW
« no previous file with comments | « media/base/video_frame_metadata.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698