Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/json_schema_compiler/util.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)
Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/util.cc
diff --git a/tools/json_schema_compiler/util.cc b/tools/json_schema_compiler/util.cc
index 983dc6682855f241207249a5247d36aa0da1d818..d1eb2e7414cc1c5941f57a211547f554caf357d0 100644
--- a/tools/json_schema_compiler/util.cc
+++ b/tools/json_schema_compiler/util.cc
@@ -72,7 +72,7 @@ bool PopulateItem(const base::Value& from, std::vector<char>* out) {
const base::Value* binary = nullptr;
if (!from.GetAsBinary(&binary))
return false;
- out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
+ *out = binary->GetBlob();
return true;
}
@@ -82,7 +82,7 @@ bool PopulateItem(const base::Value& from,
const base::Value* binary = nullptr;
if (!from.GetAsBinary(&binary))
return ReportError(from, base::Value::Type::BINARY, error);
- out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
+ *out = binary->GetBlob();
return true;
}
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698