Remove base::Value::GetAsBinary

Remove base::Value::GetAsBinary

This change removes the deprecated base::Value::GetAsBinary in favor of
base::Value::is_blob() and base::Value::GetBlob().

BUG=646113
Review-Url: https://codereview.chromium.org/2839753005
Cr-Commit-Position: refs/heads/master@{#467102}
Committed: https://chromium.googlesource.com/chromium/src/+/4e1f66f1c92879d5ae8b2f75273fc8e73975cdea

[jdoerrie, 2017-04-25 11:24:17]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 11:24:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-25 12:49:15]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org, rsesek@chromium.org

[jdoerrie, 2017-04-25 12:49:16]

rsesek@chromium.org: Please review  mojo/common/values_struct_traits.h

brettw@chromium.org: Please review the rest.

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:76:
if (value->is_blob()) {
Due to the EXPECT_TRUE above this code should never be reached if the value is
not a blob. Thus this if-clause can be removed, correct?

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
File mojo/common/values_struct_traits.h (right):

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
mojo/common/values_struct_traits.h:176: if (!value.is_blob())
Technically this if-clause is not required either given that value.GetBlob()
CHECKs that value.is_blob(). 

However, given that this clause should not generate any code in release mode and
results in earlier failures in unit tests I decided to keep it. Thoughts?

[commit-bot: I haz the power, 2017-04-25 13:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:30:43]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-04-25 14:06:42]

LGTM

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:76:
if (value->is_blob()) {
On 2017/04/25 12:49:16, jdoerrie wrote:
> Due to the EXPECT_TRUE above this code should never be reached if the value is
> not a blob. Thus this if-clause can be removed, correct?

ASSERT_TRUE would be better, since it will interrupt the control flow.

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
File mojo/common/values_struct_traits.h (right):

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
mojo/common/values_struct_traits.h:176: if (!value.is_blob())
On 2017/04/25 12:49:16, jdoerrie wrote:
> Technically this if-clause is not required either given that value.GetBlob()
> CHECKs that value.is_blob(). 
> 
> However, given that this clause should not generate any code in release mode
and
> results in earlier failures in unit tests I decided to keep it. Thoughts?

I'd keep it given the pattern in the rest of the file.

[jdoerrie, 2017-04-25 14:13:46]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:14:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-25 14:14:33]

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
(right):

https://codereview.chromium.org/2839753005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc:76:
if (value->is_blob()) {
On 2017/04/25 14:06:42, Robert Sesek wrote:
> On 2017/04/25 12:49:16, jdoerrie wrote:
> > Due to the EXPECT_TRUE above this code should never be reached if the value
is
> > not a blob. Thus this if-clause can be removed, correct?
> 
> ASSERT_TRUE would be better, since it will interrupt the control flow.

Done.

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
File mojo/common/values_struct_traits.h (right):

https://codereview.chromium.org/2839753005/diff/1/mojo/common/values_struct_t...
mojo/common/values_struct_traits.h:176: if (!value.is_blob())
On 2017/04/25 14:06:42, Robert Sesek wrote:
> On 2017/04/25 12:49:16, jdoerrie wrote:
> > Technically this if-clause is not required either given that value.GetBlob()
> > CHECKs that value.is_blob(). 
> > 
> > However, given that this clause should not generate any code in release mode
> and
> > results in earlier failures in unit tests I decided to keep it. Thoughts?
> 
> I'd keep it given the pattern in the rest of the file.

Acknowledged.

[commit-bot: I haz the power, 2017-04-25 16:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:52:19]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-04-25 19:32:50]

lgtm

[jdoerrie, 2017-04-25 20:30:10]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-04-25 20:30:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2839753005/#ps20001
(title: "ASSERT_TRUE")

[commit-bot: I haz the power, 2017-04-25 20:31:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:39:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493152210645250,
"parent_rev": "279ff60c78704ea4e9cbea0e3a30e92dfcba0c26", "commit_rev":
"4e1f66f1c92879d5ae8b2f75273fc8e73975cdea"}

[commit-bot: I haz the power, 2017-04-25 20:40:07]

Description was changed from

==========
Remove base::Value::GetAsBinary

This change removes the deprecated base::Value::GetAsBinary in favor of
base::Value::is_blob() and base::Value::GetBlob().

BUG=646113
==========

to

==========
Remove base::Value::GetAsBinary

This change removes the deprecated base::Value::GetAsBinary in favor of
base::Value::is_blob() and base::Value::GetBlob().

BUG=646113

Review-Url: https://codereview.chromium.org/2839753005
Cr-Commit-Position: refs/heads/master@{#467102}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e1f66f1c92879d5ae8b2f75273f...
==========

[commit-bot: I haz the power, 2017-04-25 20:40:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e1f66f1c92879d5ae8b2f75273f...