Remove base::Value::Get{Buffer,Size}

chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 #include <stdlib.h>
 
 #include <memory>
 #include <string>
@@ skipping 59 matching lines @@
 }
 
 void StoreDigest(std::vector<uint8_t>* digest,
                  const base::Closure& callback,
                  const base::Value* value) {
   const base::Value* binary = nullptr;
   const bool is_binary = value->GetAsBinary(&binary);
   EXPECT_TRUE(is_binary) << "Unexpected value in StoreDigest";
   if (is_binary) {
     const uint8_t* const binary_begin =
-        reinterpret_cast<const uint8_t*>(binary->GetBuffer());
-    digest->assign(binary_begin, binary_begin + binary->GetSize());
+        reinterpret_cast<const uint8_t*>(binary->GetBlob().data());
+    digest->assign(binary_begin, binary_begin + binary->GetBlob().size());

[Devlin, 2017/04/24 18:18:45]

does *digest = binary->GetBlob() work?  Or does a platform compiler complain
about uint8_t vs char?

[jdoerrie, 2017/04/25 08:50:33]

Done. I was indeed afraid that the compiler would complain here, but at least
locally it's fine. Let's see what the bots say :)

   }
 
   callback.Run();
 }
 
 // See net::SSLPrivateKey::SignDigest for the expected padding and DigestInfo
 // prefixing.
 bool RsaSign(const std::vector<uint8_t>& digest,
              crypto::RSAPrivateKey* key,
              std::vector<uint8_t>* signature) {
@@ skipping 329 matching lines @@
   chromeos::CertificateProviderService* service =
       LoadRequestPinExtension("request_pin", "basic_lock.html");
 
   EnterCode(service, base::ASCIIToUTF16("123"));
   service->pin_dialog_manager()->active_window_for_testing()->Close();
   base::RunLoop().RunUntilIdle();
 
   // The view should be set to nullptr when the window is closed.
   EXPECT_EQ(service->pin_dialog_manager()->active_view_for_testing(), nullptr);
 }