base/values.cc - Issue 2841623003: Remove base::Value::Get{Buffer,Size}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)

Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index f24646cbef6702d9b05e55a91816e1c15ac75717..ab0150cba5ff0a81688d54ba8ce6dc534ea41cdd 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -244,14 +244,6 @@ const Value::ListStorage& Value::GetList() const {

return *list_;

}

-size_t Value::GetSize() const {

- return GetBlob().size();

-const char* Value::GetBuffer() const {

- return GetBlob().data();

bool Value::GetAsBoolean(bool* out_value) const {

if (out_value && is_bool()) {

*out_value = bool_value_;

« no previous file with comments | « base/values.h ('k') | base/values_unittest.cc » ('j') | no next file with comments »