Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3764)

Unified Diff: chrome/browser/extensions/api/idltest/idltest_api.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)
Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/idltest/idltest_api.cc
diff --git a/chrome/browser/extensions/api/idltest/idltest_api.cc b/chrome/browser/extensions/api/idltest/idltest_api.cc
index da7ba52e646211927f05a85a182947f5017368d5..e6b65fb8e5117b484cca8905f3b29fd6d248c19c 100644
--- a/chrome/browser/extensions/api/idltest/idltest_api.cc
+++ b/chrome/browser/extensions/api/idltest/idltest_api.cc
@@ -17,9 +17,8 @@ namespace {
std::unique_ptr<base::ListValue> CopyBinaryValueToIntegerList(
const Value* input) {
std::unique_ptr<base::ListValue> output(new base::ListValue());
- const char* input_buffer = input->GetBuffer();
- for (size_t i = 0; i < input->GetSize(); i++) {
- output->AppendInteger(input_buffer[i]);
+ for (char c : input->GetBlob()) {
+ output->AppendInteger(c);
}
return output;
}

Powered by Google App Engine
This is Rietveld 408576698