chrome/browser/extensions/extension_action.cc - Issue 2841623003: Remove base::Value::Get{Buffer,Size}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)

Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index 00345b4c7622513825faa4b09d6850cbe214e659..49b8146c4db3632d64121661e524bfc0ee185e9a 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -130,7 +130,8 @@ bool ExtensionAction::ParseIconFromCanvasDictionary(

std::string binary_string64;

IPC::Message pickle;

if (iter.value().GetAsBinary(&image_data)) {

- pickle = IPC::Message(image_data->GetBuffer(), image_data->GetSize());

+ pickle = IPC::Message(image_data->GetBlob().data(),

+ image_data->GetBlob().size());

} else if (iter.value().GetAsString(&binary_string64)) {

std::string binary_string;

if (!base::Base64Decode(binary_string64, &binary_string))