Remove base::Value::Get{Buffer,Size}

chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 #include <stdlib.h>
 
 #include <memory>
 #include <string>
@@ skipping 58 matching lines @@
   callback.Run();
 }
 
 void StoreDigest(std::vector<uint8_t>* digest,
                  const base::Closure& callback,
                  const base::Value* value) {
   const base::Value* binary = nullptr;
   const bool is_binary = value->GetAsBinary(&binary);
   EXPECT_TRUE(is_binary) << "Unexpected value in StoreDigest";
   if (is_binary) {
-    const uint8_t* const binary_begin =
-        reinterpret_cast<const uint8_t*>(binary->GetBuffer());
-    digest->assign(binary_begin, binary_begin + binary->GetSize());
+    *digest = binary->GetBlob();

[jdoerrie, 2017/04/25 11:09:08]

The linux_chromium_chromeos_* bots complain unfortunately, I will revert this:

.../extensions/api/certificate_provider/certificate_provider_apitest.cc:79:13:
error: no viable overloaded '='
    *digest = binary->GetBlob();
    ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
.../debian_jessie_amd64-sysroot/usr/include/c++/4.8/bits/stl_vector.h:427:7:
note: candidate function not viable: no known conversion from 'const
vector<char, allocator<char>>' to 'const vector<unsigned char,
allocator<unsigned char>>' for 1st argument
      operator=(const vector& __x);

[Devlin, 2017/04/25 15:04:11]

Ah well - worth a shot!

   }
 
   callback.Run();
 }
 
 // See net::SSLPrivateKey::SignDigest for the expected padding and DigestInfo
 // prefixing.
 bool RsaSign(const std::vector<uint8_t>& digest,
              crypto::RSAPrivateKey* key,
              std::vector<uint8_t>* signature) {
@@ skipping 329 matching lines @@
   chromeos::CertificateProviderService* service =
       LoadRequestPinExtension("request_pin", "basic_lock.html");
 
   EnterCode(service, base::ASCIIToUTF16("123"));
   service->pin_dialog_manager()->active_window_for_testing()->Close();
   base::RunLoop().RunUntilIdle();
 
   // The view should be set to nullptr when the window is closed.
   EXPECT_EQ(service->pin_dialog_manager()->active_view_for_testing(), nullptr);
 }