Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)

Created:
3 years, 8 months ago by gab
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, binji+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, eae+blinkwatch, dcheng, teravest+watch_chromium.org, yusukes+watch_chromium.org, creis+watch_chromium.org, kinuko+watch, Sam Clegg, miu+watch_chromium.org, jdonnelly+watch_chromium.org, awdf+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, jochen+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, tzik, blink-reviews-api_chromium.org, ihf+watch_chromium.org, mlamouri+watch-content_chromium.org, subresource-filter-reviews_chromium.org, derat+watch_chromium.org, extensions-reviews_chromium.org, Peter Beverloo, rwlbuis, mlamouri+watch-notifications_chromium.org, sof, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, kalyank, piman+watch_chromium.org, bradnelson+warch_chromium.org, darin (slow to review), sync-reviews_chromium.org, Matt Giuca, rjkroege, mlamouri+watch-test-runner_chromium.org, tfarina, Aaron Boodman, mac-reviews_chromium.org, danakj+watch_chromium.org, scheduler-bugs_chromium.org, einbinder+watch-test-runner_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace "nested message loop" with "nested run loop" in comments. Following https://codereview.chromium.org/2818533003/ BUG=703346 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2828913003 Cr-Commit-Position: refs/heads/master@{#469674} Committed: https://chromium.googlesource.com/chromium/src/+/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -150 lines) Patch
M ash/drag_drop/drag_drop_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/run_loop.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_navigation_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc/desktop_capture_access_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/subresource_filter/test_ruleset_publisher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/chrome_app_list_test_support.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/printing/common/print_messages.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host_client_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_download_request_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_frame_navigation_observer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_navigation_observer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/host_globals.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/ppb_flash_message_loop_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/result_catcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_beta/c/struct_p_p_b___message_loop__1__0.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_beta/cpp/classpp_1_1_message_loop.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_dev/c/struct_p_p_b___message_loop__1__0.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_dev/cpp/classpp_1_1_message_loop.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_stable/c/struct_p_p_b___message_loop__1__0.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/pepper_stable/cpp/classpp_1_1_message_loop.html View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/ppb_message_loop.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/private/ppb_flash_message_loop.idl View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ppapi/api/private/ppb_testing_private.idl View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_message_loop.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/private/ppb_flash_message_loop.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/private/ppb_testing_private.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/message_loop.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/flash_menu_resource.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_case.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_graphics_2d.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_utils.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/tests/test_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_manager_client_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PluginScriptForbiddenScope.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_time_observer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/mus/drag_drop_controller_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/mus_mouse_location_updater.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/shell.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_requestor.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/test/event_generator.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_cocoa_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl_interface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_move_loop.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/public/window_move_client.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
gab
Dana PTaL, a mere search and replace, I'll TBR you to bypass other owners for ...
3 years, 8 months ago (2017-04-20 16:03:59 UTC) #3
danakj
LGTM
3 years, 8 months ago (2017-04-20 16:14:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828913003/1
3 years, 7 months ago (2017-05-05 14:07:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/261583)
3 years, 7 months ago (2017-05-05 14:11:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828913003/10001
3 years, 7 months ago (2017-05-05 14:22:43 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 16:24:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/2998ee7b318fc904fdaf9faa3db5...

Powered by Google App Engine
This is Rietveld 408576698