Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: third_party/WebKit/Source/web/tests/TouchActionTest.cpp

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 TouchActionTrackingWebWidgetClient&); 122 TouchActionTrackingWebWidgetClient&);
123 123
124 std::string base_url_; 124 std::string base_url_;
125 FrameTestHelpers::WebViewHelper web_view_helper_; 125 FrameTestHelpers::WebViewHelper web_view_helper_;
126 }; 126 };
127 127
128 void TouchActionTest::RunTouchActionTest(std::string file) { 128 void TouchActionTest::RunTouchActionTest(std::string file) {
129 TouchActionTrackingWebWidgetClient client; 129 TouchActionTrackingWebWidgetClient client;
130 130
131 // runTouchActionTest() loads a document in a frame, setting up a 131 // runTouchActionTest() loads a document in a frame, setting up a
132 // nested message loop. Should any Oilpan GC happen while it is in 132 // nested run loop. Should any Oilpan GC happen while it is in
133 // effect, the implicit assumption that we're outside any event 133 // effect, the implicit assumption that we're outside any event
134 // loop (=> there being no pointers on the stack needing scanning) 134 // loop (=> there being no pointers on the stack needing scanning)
135 // when that GC strikes will no longer hold. 135 // when that GC strikes will no longer hold.
136 // 136 //
137 // To ensure that the references on the stack are also traced, we 137 // To ensure that the references on the stack are also traced, we
138 // turn them into persistent, stack allocated references. This 138 // turn them into persistent, stack allocated references. This
139 // workaround is sufficient to handle this artificial test 139 // workaround is sufficient to handle this artificial test
140 // scenario. 140 // scenario.
141 WebView* web_view = SetupTest(file, client); 141 WebView* web_view = SetupTest(file, client);
142 142
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 417
418 TEST_F(TouchActionTest, ShadowDOM) { 418 TEST_F(TouchActionTest, ShadowDOM) {
419 RunShadowDOMTest("touch-action-shadow-dom.html"); 419 RunShadowDOMTest("touch-action-shadow-dom.html");
420 } 420 }
421 421
422 TEST_F(TouchActionTest, Pan) { 422 TEST_F(TouchActionTest, Pan) {
423 RunTouchActionTest("touch-action-pan.html"); 423 RunTouchActionTest("touch-action-pan.html");
424 } 424 }
425 425
426 } // namespace blink 426 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698