third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc - Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/PluginScriptForbiddenScope.h ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc

index 83f6d480fdf35ee55815736eddcf4dcbd396577b..f1526c6db3cbb480fbfc8dac7bfc22ed46940dab 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc

@@ -145,7 +145,7 @@ TEST_F(QueueingTimeEstimatorTest,

EXPECT_EQ(base::TimeDelta::FromMilliseconds(5500), estimated_queueing_time);

}

-// Tasks containing nested message loops may be extremely long without

+// Tasks containing nested run loops may be extremely long without

// negatively impacting user experience. Ignore such tasks.

TEST_F(QueueingTimeEstimatorTest, IgnoresTasksWithNestedMessageLoops) {

TestQueueingTimeEstimatorClient client;

@@ -163,7 +163,7 @@ TEST_F(QueueingTimeEstimatorTest, IgnoresTasksWithNestedMessageLoops) {

estimator.OnBeginNestedRunLoop();

estimator.OnTopLevelTaskCompleted(time);

- // Perform an additional task after the nested message loop. A 1 second task

+ // Perform an additional task after the nested run loop. A 1 second task

// in a 5 second window results in a 100ms expected queueing time.

estimator.OnTopLevelTaskStarted(time);

time += base::TimeDelta::FromMilliseconds(1000);