ui/views/controls/menu/menu_runner_impl.cc - Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_impl.cc

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_runner_impl.cc

diff --git a/ui/views/controls/menu/menu_runner_impl.cc b/ui/views/controls/menu/menu_runner_impl.cc

index b5f4ba2c840f525fa5c89a1fac10583ebaa78a60..49c34b6ab7a06e8bffc5fe4f7e6853bd4fba564e 100644

--- a/ui/views/controls/menu/menu_runner_impl.cc

+++ b/ui/views/controls/menu/menu_runner_impl.cc

@@ -47,7 +47,7 @@ void MenuRunnerImpl::Release() {

if (delete_after_run_)

return; // We already canceled.

- // The menu is running a nested message loop, we can't delete it now

+ // The menu is running a nested run loop, we can't delete it now

// otherwise the stack would be in a really bad state (many frames would

// have deleted objects on them). Instead cancel the menu, when it returns

// Holder will delete itself.