Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_aura.h" 5 #include "content/browser/web_contents/web_contents_view_aura.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 934 matching lines...) Expand 10 before | Expand all | Expand 10 after
945 const gfx::Vector2d& image_offset, 945 const gfx::Vector2d& image_offset,
946 const DragEventSourceInfo& event_info, 946 const DragEventSourceInfo& event_info,
947 RenderWidgetHostImpl* source_rwh) { 947 RenderWidgetHostImpl* source_rwh) {
948 aura::Window* root_window = GetNativeView()->GetRootWindow(); 948 aura::Window* root_window = GetNativeView()->GetRootWindow();
949 if (!aura::client::GetDragDropClient(root_window)) { 949 if (!aura::client::GetDragDropClient(root_window)) {
950 web_contents_->SystemDragEnded(source_rwh); 950 web_contents_->SystemDragEnded(source_rwh);
951 return; 951 return;
952 } 952 }
953 953
954 // Grab a weak pointer to the RenderWidgetHost, since it can be destroyed 954 // Grab a weak pointer to the RenderWidgetHost, since it can be destroyed
955 // during the drag and drop nested message loop in StartDragAndDrop. 955 // during the drag and drop nested run loop in StartDragAndDrop.
956 // For example, the RenderWidgetHost can be deleted if a cross-process 956 // For example, the RenderWidgetHost can be deleted if a cross-process
957 // transfer happens while dragging, since the RenderWidgetHost is deleted in 957 // transfer happens while dragging, since the RenderWidgetHost is deleted in
958 // that case. 958 // that case.
959 base::WeakPtr<RenderWidgetHostImpl> source_rwh_weak_ptr = 959 base::WeakPtr<RenderWidgetHostImpl> source_rwh_weak_ptr =
960 source_rwh->GetWeakPtr(); 960 source_rwh->GetWeakPtr();
961 961
962 drag_start_process_id_ = source_rwh->GetProcess()->GetID(); 962 drag_start_process_id_ = source_rwh->GetProcess()->GetID();
963 drag_start_view_id_ = GetRenderViewHostID(web_contents_->GetRenderViewHost()); 963 drag_start_view_id_ = GetRenderViewHostID(web_contents_->GetRenderViewHost());
964 964
965 ui::TouchSelectionController* selection_controller = GetSelectionController(); 965 ui::TouchSelectionController* selection_controller = GetSelectionController();
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 bool allow_multiple_selection) { 1340 bool allow_multiple_selection) {
1341 NOTIMPLEMENTED() << " show " << items.size() << " menu items"; 1341 NOTIMPLEMENTED() << " show " << items.size() << " menu items";
1342 } 1342 }
1343 1343
1344 void WebContentsViewAura::HidePopupMenu() { 1344 void WebContentsViewAura::HidePopupMenu() {
1345 NOTIMPLEMENTED(); 1345 NOTIMPLEMENTED();
1346 } 1346 }
1347 #endif 1347 #endif
1348 1348
1349 } // namespace content 1349 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698