Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: ui/aura/window_event_dispatcher_unittest.cc

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/window_event_dispatcher.cc ('k') | ui/base/clipboard/clipboard_aurax11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_event_dispatcher_unittest.cc
diff --git a/ui/aura/window_event_dispatcher_unittest.cc b/ui/aura/window_event_dispatcher_unittest.cc
index 135849f1ca6e97557ffac69a31c8ea7ed9b27c34..ba60827254a60784a50b041be3daed725f854c2d 100644
--- a/ui/aura/window_event_dispatcher_unittest.cc
+++ b/ui/aura/window_event_dispatcher_unittest.cc
@@ -2209,8 +2209,8 @@ TEST_P(WindowEventDispatcherTestInHighDPI, TouchMovesHeldOnScroll) {
root_window()->RemovePreTargetHandler(&recorder);
}
-// This handler triggers a nested message loop when it receives a right click
-// event, and runs a single callback in the nested message loop.
+// This handler triggers a nested run loop when it receives a right click
+// event, and runs a single callback in the nested run loop.
class TriggerNestedLoopOnRightMousePress : public ui::test::TestEventHandler {
public:
explicit TriggerNestedLoopOnRightMousePress(const base::Closure& callback)
@@ -2244,8 +2244,8 @@ class TriggerNestedLoopOnRightMousePress : public ui::test::TestEventHandler {
DISALLOW_COPY_AND_ASSIGN(TriggerNestedLoopOnRightMousePress);
};
-// Tests that if dispatching a 'held' event triggers a nested message loop, then
-// the events that are dispatched from the nested message loop are transformed
+// Tests that if dispatching a 'held' event triggers a nested run loop, then
+// the events that are dispatched from the nested run loop are transformed
// correctly.
TEST_P(WindowEventDispatcherTestInHighDPI,
EventsTransformedInRepostedEventTriggeredNestedLoop) {
@@ -2911,7 +2911,7 @@ class NestedLocationDelegate : public test::TestWindowDelegate {
void InRunMessageLoop(base::RunLoop* run_loop) {
++nested_message_loop_count_;
- // Nested message loops trigger falling back to using the location from
+ // nested run loops trigger falling back to using the location from
// WindowTreeClient, which is 0,0.
EXPECT_EQ(gfx::Point(0, 0), Env::GetInstance()->last_mouse_location());
run_loop->Quit();
« no previous file with comments | « ui/aura/window_event_dispatcher.cc ('k') | ui/base/clipboard/clipboard_aurax11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698