Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 public: 440 public:
441 RenderFrameHostCreatedObserver(WebContents* web_contents, 441 RenderFrameHostCreatedObserver(WebContents* web_contents,
442 int expected_frame_count) 442 int expected_frame_count)
443 : WebContentsObserver(web_contents), 443 : WebContentsObserver(web_contents),
444 expected_frame_count_(expected_frame_count), 444 expected_frame_count_(expected_frame_count),
445 frames_created_(0), 445 frames_created_(0),
446 message_loop_runner_(new MessageLoopRunner) {} 446 message_loop_runner_(new MessageLoopRunner) {}
447 447
448 ~RenderFrameHostCreatedObserver() override; 448 ~RenderFrameHostCreatedObserver() override;
449 449
450 // Runs a nested message loop and blocks until the expected number of 450 // Runs a nested run loop and blocks until the expected number of
451 // RenderFrameHosts is created. 451 // RenderFrameHosts is created.
452 void Wait(); 452 void Wait();
453 453
454 private: 454 private:
455 // WebContentsObserver 455 // WebContentsObserver
456 void RenderFrameCreated(RenderFrameHost* render_frame_host) override; 456 void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
457 457
458 // The number of RenderFrameHosts to wait for. 458 // The number of RenderFrameHosts to wait for.
459 int expected_frame_count_; 459 int expected_frame_count_;
460 460
(...skipping 9703 matching lines...) Expand 10 before | Expand all | Expand 10 after
10164 names.insert(root->children[0]->frame_entry->frame_unique_name()); 10164 names.insert(root->children[0]->frame_entry->frame_unique_name());
10165 } 10165 }
10166 10166
10167 // More than one entry in the set means that the subframe frame navigation 10167 // More than one entry in the set means that the subframe frame navigation
10168 // entries didn't have a consistent unique name. This will break history 10168 // entries didn't have a consistent unique name. This will break history
10169 // navigations =( 10169 // navigations =(
10170 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!"; 10170 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!";
10171 } 10171 }
10172 10172
10173 } // namespace content 10173 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698