Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 (window_rect.Height() - viewport_size.Height())); 110 (window_rect.Height() - viewport_size.Height()));
111 111
112 page->GetChromeClient().SetWindowRectWithAdjustment(window_rect, frame); 112 page->GetChromeClient().SetWindowRectWithAdjustment(window_rect, frame);
113 page->GetChromeClient().Show(policy); 113 page->GetChromeClient().Show(policy);
114 114
115 if (opener_frame.GetDocument()->IsSandboxed( 115 if (opener_frame.GetDocument()->IsSandboxed(
116 kSandboxPropagatesToAuxiliaryBrowsingContexts)) 116 kSandboxPropagatesToAuxiliaryBrowsingContexts))
117 frame.Loader().ForceSandboxFlags( 117 frame.Loader().ForceSandboxFlags(
118 opener_frame.GetSecurityContext()->GetSandboxFlags()); 118 opener_frame.GetSecurityContext()->GetSandboxFlags());
119 119
120 // This call may suspend the execution by running nested message loop. 120 // This call may suspend the execution by running nested run loop.
121 probe::windowCreated(&opener_frame, &frame); 121 probe::windowCreated(&opener_frame, &frame);
122 created = true; 122 created = true;
123 return &frame; 123 return &frame;
124 } 124 }
125 125
126 static Frame* CreateWindowHelper(LocalFrame& opener_frame, 126 static Frame* CreateWindowHelper(LocalFrame& opener_frame,
127 LocalFrame& active_frame, 127 LocalFrame& active_frame,
128 LocalFrame& lookup_frame, 128 LocalFrame& lookup_frame,
129 const FrameLoadRequest& request, 129 const FrameLoadRequest& request,
130 const WindowFeatures& features, 130 const WindowFeatures& features,
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 } 293 }
294 294
295 // TODO(japhet): Form submissions on RemoteFrames don't work yet. 295 // TODO(japhet): Form submissions on RemoteFrames don't work yet.
296 FrameLoadRequest new_request(0, request.GetResourceRequest()); 296 FrameLoadRequest new_request(0, request.GetResourceRequest());
297 new_request.SetForm(request.Form()); 297 new_request.SetForm(request.Form());
298 if (new_frame->IsLocalFrame()) 298 if (new_frame->IsLocalFrame())
299 ToLocalFrame(new_frame)->Loader().Load(new_request); 299 ToLocalFrame(new_frame)->Loader().Load(new_request);
300 } 300 }
301 301
302 } // namespace blink 302 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | third_party/WebKit/Source/core/page/DragController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698