Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 2828913003: Replace "nested message loop" with "nested run loop" in comments. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | extensions/test/result_catcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_ 5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_
6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_ 6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <ostream> 10 #include <ostream>
(...skipping 27 matching lines...) Expand all
38 38
39 namespace content { 39 namespace content {
40 40
41 class LayoutTestBluetoothChooserFactory; 41 class LayoutTestBluetoothChooserFactory;
42 class LayoutTestDevToolsBindings; 42 class LayoutTestDevToolsBindings;
43 class RenderFrameHost; 43 class RenderFrameHost;
44 class RenderProcessHost; 44 class RenderProcessHost;
45 class Shell; 45 class Shell;
46 46
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 // Android uses a nested message loop for running layout tests because the 48 // Android uses a nested run loop for running layout tests because the
49 // default message loop, provided by the system, does not offer a blocking 49 // default message loop, provided by the system, does not offer a blocking
50 // Run() method. The loop itself, implemented as NestedMessagePumpAndroid, 50 // Run() method. The loop itself, implemented as NestedMessagePumpAndroid,
51 // uses a base::WaitableEvent allowing it to sleep until more events arrive. 51 // uses a base::WaitableEvent allowing it to sleep until more events arrive.
52 class ScopedAllowWaitForAndroidLayoutTests { 52 class ScopedAllowWaitForAndroidLayoutTests {
53 private: 53 private:
54 base::ThreadRestrictions::ScopedAllowWait wait; 54 base::ThreadRestrictions::ScopedAllowWait wait;
55 }; 55 };
56 #endif 56 #endif
57 57
58 class BlinkTestResultPrinter { 58 class BlinkTestResultPrinter {
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 // waiting on the UI thread while layout tests are being ran. 297 // waiting on the UI thread while layout tests are being ran.
298 ScopedAllowWaitForAndroidLayoutTests reduced_restrictions_; 298 ScopedAllowWaitForAndroidLayoutTests reduced_restrictions_;
299 #endif 299 #endif
300 300
301 DISALLOW_COPY_AND_ASSIGN(BlinkTestController); 301 DISALLOW_COPY_AND_ASSIGN(BlinkTestController);
302 }; 302 };
303 303
304 } // namespace content 304 } // namespace content
305 305
306 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_ 306 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_BLINK_TEST_CONTROLLER_H_
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | extensions/test/result_catcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698