Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018
Review-Url: https://codereview.chromium.org/2826983002
Cr-Commit-Position: refs/heads/master@{#466279}
Committed: https://chromium.googlesource.com/chromium/src/+/71e2c38925b47383e6a7f3fafe7296d99d8baa1c

[nikhil.sahni, 2017-04-19 12:08:19]

Description was changed from

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

Bug=713018

BUG=
==========

to

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018
==========

[nikhil.sahni, 2017-04-19 12:08:36]

Description was changed from

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018
==========

to

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-04-19 13:23:30]

nikhil.sahni@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2017-04-19 13:26:19]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 13:26:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Srirama, 2017-04-19 13:27:03]

Peer review looks good, running CQ dry run to see if any more tests need update.

[commit-bot: I haz the power, 2017-04-19 14:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:36:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Srirama, 2017-04-20 05:14:53]

Update global-interface-listing-expected.txt files as well with the new method
name.

[Srirama, 2017-04-20 05:50:33]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 05:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 06:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 06:53:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Srirama, 2017-04-20 08:49:11]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 08:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 10:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 10:33:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nikhil.sahni, 2017-04-20 11:58:23]

Description was changed from

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018

R=SamsungPeerReview
==========

to

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018
==========

[nikhil.sahni, 2017-04-20 11:58:23]

nikhil.sahni@samsung.com changed reviewers:
+ nhiroki@chromium.org, shanmuga.m@samsung.com

[nikhil.sahni, 2017-04-20 12:00:18]

Hi Nhiroki,

All layout tests are passed related to the change, getting one unexpected layout
test failure and it keeps changing :-) from variable-declaration-16.html to
variable-declaration-17.html. 

I would like you to review once and guide me further.

[nhiroki, 2017-04-21 06:56:39]

LGTM. Thank you for working on this!

On 2017/04/20 12:00:18, nikhil.sahni wrote:
> Hi Nhiroki,
> 
> All layout tests are passed related to the change, getting one unexpected
layout
> test failure and it keeps changing :-) from variable-declaration-16.html to
> variable-declaration-17.html. 
> 
> I would like you to review once and guide me further.

It looks like they were flaky. I think it's ok to land this as is.

[nikhil.sahni, 2017-04-21 07:01:16]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-04-21 07:01:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 07:07:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492758076031670,
"parent_rev": "bffdac48c4e7381755e0a09ef5f431e80c432b1b", "commit_rev":
"71e2c38925b47383e6a7f3fafe7296d99d8baa1c"}

[commit-bot: I haz the power, 2017-04-21 07:07:49]

Description was changed from

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018
==========

to

==========
Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG=713018

Review-Url: https://codereview.chromium.org/2826983002
Cr-Commit-Position: refs/heads/master@{#466279}
Committed:
https://chromium.googlesource.com/chromium/src/+/71e2c38925b47383e6a7f3fafe72...
==========

[commit-bot: I haz the power, 2017-04-21 07:07:50]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/71e2c38925b47383e6a7f3fafe72...