Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js

Issue 2826983002: Rename Worklet.import() to Worklet.addModule(). (Closed)
Patch Set: Fixing Layout Tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js b/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
index ea341b8af574d8e90d10294c4b4cea8199da1134..2ce11fe3b8beb6751ed8c9e7d9967ec3e77b4e88 100644
--- a/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
+++ b/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
@@ -6,38 +6,38 @@ function runImportTests(worklet, opt_path) {
const path = opt_path || '';
promise_test(function() {
- return worklet.import(path + 'resources/empty-worklet-script.js').then(function(undefined_arg) {
+ return worklet.addModule(path + 'resources/empty-worklet-script.js').then(function(undefined_arg) {
assert_equals(undefined_arg, undefined, 'Promise should resolve with no arguments.');
});
}, 'Importing a script resolves the given promise.');
promise_test(function() {
return Promise.all([
- worklet.import(path + 'resources/empty-worklet-script.js?1'),
- worklet.import(path + 'resources/empty-worklet-script.js?2'),
- worklet.import(path + 'resources/empty-worklet-script.js?3')
+ worklet.addModule(path + 'resources/empty-worklet-script.js?1'),
+ worklet.addModule(path + 'resources/empty-worklet-script.js?2'),
+ worklet.addModule(path + 'resources/empty-worklet-script.js?3')
]).then(function(undefined_args) {
assert_array_equals(undefined_args, [undefined, undefined, undefined], 'Promise should resolve with no arguments.');
});
}, 'Importing scripts resolves all the given promises.');
promise_test(function() {
- return worklet.import(path + 'resources/throwing-worklet-script.js').then(function(undefined_arg) {
+ return worklet.addModule(path + 'resources/throwing-worklet-script.js').then(function(undefined_arg) {
assert_equals(undefined_arg, undefined, 'Promise should resolve with no arguments.');
});
}, 'Importing a script which throws should still resolve the given promise.');
promise_test(function() {
- return worklet.import(path + 'non-existant-worklet-script.js').then(function() {
- assert_unreached('import should fail.');
+ return worklet.addModule(path + 'non-existant-worklet-script.js').then(function() {
+ assert_unreached('addModule should fail.');
}).catch(function(error) {
assert_equals(error.name, 'NetworkError', 'error should be a NetworkError.');
});
}, 'Importing a non-existant script rejects the given promise with a NetworkError.');
promise_test(function() {
- return worklet.import('http://invalid:123$').then(function() {
- assert_unreached('import should fail.');
+ return worklet.addModule('http://invalid:123$').then(function() {
+ assert_unreached('addModule should fail.');
}).catch(function(error) {
assert_equals(error.name, 'SyntaxError', 'error should be a SyntaxError.');
});

Powered by Google App Engine
This is Rietveld 408576698