third_party/WebKit/Source/core/workers/Worklet.h - Issue 2826983002: Rename Worklet.import() to Worklet.addModule().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/Worklet.h

Issue 2826983002: Rename Worklet.import() to Worklet.addModule(). (Closed)

Patch Set: Fixing Layout Tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/Worklet.h

diff --git a/third_party/WebKit/Source/core/workers/Worklet.h b/third_party/WebKit/Source/core/workers/Worklet.h

index f482229f2e93cd6f16668eaece83181980d592a2..07122bda3c915bba916cf1c790d422169b002349 100644

--- a/third_party/WebKit/Source/core/workers/Worklet.h

+++ b/third_party/WebKit/Source/core/workers/Worklet.h

@@ -34,8 +34,8 @@ class CORE_EXPORT Worklet : public GarbageCollectedFinalized<Worklet>,

virtual bool IsInitialized() const { return true; }

// Worklet.idl

- // import() imports ES6 module scripts.

- virtual ScriptPromise import(ScriptState*, const String& url) = 0;

+ // addModule() imports ES6 module scripts.

+ virtual ScriptPromise addModule(ScriptState*, const String& url) = 0;

// Returns a proxy to WorkletGlobalScope on the context thread.

virtual WorkletGlobalScopeProxy* GetWorkletGlobalScopeProxy() const = 0;