third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html - Issue 2826983002: Rename Worklet.import() to Worklet.addModule().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html

Issue 2826983002: Rename Worklet.import() to Worklet.addModule(). (Closed)

Patch Set: Fixing Layout Tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked.html ('k') | third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html b/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html

index bbba10226d11bbccd1cd43cf5927cdbf01e04ddb..de70b503acdfaf77b43a41a079278d079afefe1a 100644

--- a/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html

+++ b/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html

@@ -1,6 +1,6 @@

<!DOCTYPE html>

-<title>Worklet: import() on a detached iframe</title>

+<title>Worklet: addModule() on a detached iframe</title>

<body>

</body>

@@ -18,7 +18,7 @@ function with_iframe(url) {

}

// This test should be in chromium/ because the spec does not define behavior in

-// the case where import() is called from a detached frame.

+// the case where addModule() is called from a detached frame.

promise_test(t => {

const kFrameUrl = 'resources/blank.html';

const kScriptUrl = 'resources/empty-worklet-script.js';

@@ -27,10 +27,10 @@ promise_test(t => {

.then(frame => {

let worklet = frame.contentWindow.paintWorklet;

frame.remove();

- return worklet.import(kScriptUrl);

+ return worklet.addModule(kScriptUrl);

})

- .then(() => assert_unreached('import() should fail.'))

+ .then(() => assert_unreached('addModule() should fail.'))

.catch(e => assert_equals(e.name, 'InvalidStateError', e));

-}, 'import() on a detached iframe should be rejected.');

+}, 'addModule() on a detached iframe should be rejected.');

</script>